After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 106695 - Please use ngettext for handling plurals in file-roller
Please use ngettext for handling plurals in file-roller
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks: 116236
 
 
Reported: 2003-02-21 10:03 UTC by Christian Rose
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch. (1.09 KB, patch)
2003-09-19 18:25 UTC, Christian Neumair
none Details | Review
Proposed patch, removed inner gettext calls. (1.08 KB, patch)
2003-09-21 07:32 UTC, Christian Neumair
none Details | Review

Description Christian Rose 2003-02-21 10:03:31 UTC
#: src/window.c:846
#, c-format
msgid "1 file (%s)"

#: src/window.c:849
#, c-format
msgid "%d files (%s)"

#: src/window.c:857
#, c-format
msgid "1 file selected (%s)"

#: src/window.c:860
#, c-format
msgid "%d files selected (%s)"


As mentioned in
http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#plurals,
this way of handling plurals is broken for many locales. A way to solve
this is by using ngettext instead as mentioned in that document.
A simple code example of code using ngettext:

  g_printf (ngettext ("Found %d file.", "Found %d files.", nbr_of_files),
nbr_of_files);
Comment 1 Christian Neumair 2003-09-19 18:25:16 UTC
Created attachment 20106 [details] [review]
Proposed patch.
Comment 2 Christian Neumair 2003-09-21 07:32:45 UTC
Created attachment 20156 [details] [review]
Proposed patch, removed inner gettext calls.
Comment 3 Christian Rose 2003-09-30 08:25:53 UTC
Can we revisit this issue now?
Comment 4 Christian Neumair 2003-12-30 19:56:07 UTC
Has already been fixed. Closing.

regs,
 Chris