GNOME Bugzilla – Bug 104990
File-Roller problems with src/Makefile.am
Last modified: 2004-12-22 21:47:04 UTC
Hello, ;----- 2003-01-22 Thomas Vander Stichele <thomas at apestaart dot org> * src/Makefile.am: remove LIBOBJS, nothing sets it ;----- 2003-01-22 Paolo Bacchilega <paolo.bacch@tin.it> * src/Makefile.am (file_roller_LDADD): revert Thomas Vander Stichele commit, Thomas LIBOBJS is setted on systems that do not have the FNM_CASEFOLD constant defined (e.g. Solaris), if it does not build for you use automake 1.7.2 and autoconf 2.57. ;----- Paolo, I the remove from Thomas was correct. Even I made a little patch here to remove LIBOBJS here but never had the time sending it in. You wrote that Thomas should use automake 1.7.2 and autoconf 2.57. I'm using exactly this setup here and the LIBOBJ issue still shows up. I think you need add some AC_LIBOBJ thingy in the configure.ac/in file. Please review this because it's in no way possible to create a sane configure script and makefiles. Regrards.
Created attachment 14019 [details] [review] src/Makefile.am diff
Removing @LIBOBJS@ from the makefile is wrong, and will break the build on other systems. The problem is that older automakes aren't picking up that newer autoconf's are actually defining LIBOJBS. The correct fix to get it working with older automakes is to add the following line to configure.in: AC_SUBST(LIBOBJS) Strictly speaking this is redundant, but it is not harmful (and will stop old automakes complaining).
this is a dup. *** This bug has been marked as a duplicate of 101480 ***
Hello James, I would have appreciated if you at least have READ my comment before answering with 'old' automake and autoconf. I'm already using automake 1.7.2 autoconf 2.57 But I'm still getting this error on my Linux System. I also went to ftp.gnu.org and looked if there are any newer versions of these tools. The answer is 'Negative'. I would suggest to re-open this bug again since it's still there otherwise I can't help it and it will stay forever there.
Maybe we are using different types of automakes/autoconfs. But since I get my tools from a sane location (GNU ftp) I tend to call them trustable versions. Maybe some 'hacked' distributive version is acting differently. I recommend to check this up.
Ali, I marked your bug as a duplicate of another file-roller bug (that has not been marked resolved yet). The other bug contains a patch that is essentially the same as what you have posted, so is most likely to be the same problem. Feel free to add yourself to the CC list of the other bug. If you feel that this bug is unique, please provide more information to back that up. From what I can see, the problem is that the new autoconf calls AC_SUBST for LIBOBJS like so: AC_SUBST([LIB@&t@OBJS], [$ac_libobjs]) while automake is using simple regular expressions to work out what makefile substitutions are defined, which is the reason for the error message.