After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794276 - msdk: fix miscellaneous bugs
msdk: fix miscellaneous bugs
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.14.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 789886
 
 
Reported: 2018-03-13 02:47 UTC by Hyunjun Ko
Modified: 2018-03-13 21:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
msdk: fix typo (2.19 KB, patch)
2018-03-13 02:55 UTC, Hyunjun Ko 		committed Details | Review
msdk: adds new debug category (1.55 KB, patch)
2018-03-13 02:56 UTC, Hyunjun Ko 		committed Details | Review
msdk: libva: remove unnecessary code and comments (899 bytes, patch)
2018-03-13 02:56 UTC, Hyunjun Ko 		committed Details | Review

Description Hyunjun Ko 2018-03-13 02:47:43 UTC 
Found some mistakes while working on msdk.
Comment 1 Hyunjun Ko 2018-03-13 02:55:57 UTC 
Created attachment 369600 [details] [review]
msdk: fix typo
Comment 2 Hyunjun Ko 2018-03-13 02:56:16 UTC 
Created attachment 369601 [details] [review]
msdk: adds new debug category
Comment 3 Hyunjun Ko 2018-03-13 02:56:31 UTC 
Created attachment 369602 [details] [review]
msdk: libva: remove unnecessary code and comments
Comment 4 sreerenj 2018-03-13 21:10:39 UTC 
Review of attachment 369600 [details] [review]:

lgtm
Comment 5 sreerenj 2018-03-13 21:15:26 UTC 
Review of attachment 369601 [details] [review]:

::: sys/msdk/msdk.c
@@ +35,3 @@
 
+GST_DEBUG_CATEGORY_EXTERN (gst_msdk_debug);
+#define GST_CAT_DEFAULT gst_msdk_debug

gst_msdk_debug is not defined in msdk.c
Comment 6 sreerenj 2018-03-13 21:16:29 UTC 
Review of attachment 369602 [details] [review]:

lgtm
Comment 7 sreerenj 2018-03-13 21:19:49 UTC 
Review of attachment 369601 [details] [review]:

LGTM

::: sys/msdk/msdk.c
@@ +35,3 @@
 
+GST_DEBUG_CATEGORY_EXTERN (gst_msdk_debug);
+#define GST_CAT_DEFAULT gst_msdk_debug

Aha, my mistake! It is there. Sorry.
Comment 8 sreerenj 2018-03-13 21:24:21 UTC 
Review of attachment 369600 [details] [review]:

commit 443b3c98fa70adce242aa2e02c6819cedc39ff5d
Comment 9 sreerenj 2018-03-13 21:24:40 UTC 
Review of attachment 369601 [details] [review]:

commit 6547b638c55f0f1339783ea0a8829fdcfbd1bb84
Comment 10 sreerenj 2018-03-13 21:25:05 UTC 
Review of attachment 369602 [details] [review]:

lgtm

commit 52f669bf43e8c211fbd2e3642137f7e036317d82