GNOME Bugzilla – Bug 792278
Remove HAVE_LOCALE_H checks
Last modified: 2018-01-07 06:52:44 UTC
I cannot find HAVE_LOCALE_H in config.h, and gnome-keyring already includes locale.h unconditionally. Can we simply remove the checks? Both locale.h and setlocale are in the standard C. If setlocale is not called before using gettext, running 'gnome-keyring-daemon --help' on FreeBSD with zh_TW.UTF-8 will show broken help messages: ??? gnome-keyring-daemon [???] - The Gnome Keyring Daemon ????? -h, --help ??????? ??????? -s, --start Start a dameon or initialize an already running daemon. -r, --replace Replace the daemon for this desktop login environment. -f, --foreground Run in the foreground -d, --daemonize Run as a daemon -l, --login Run by PAM for a user login. Read login password from stdin --unlock Prompt for login keyring password, or read from stdin -c, --components=pkcs11,secrets,ssh The optional components to run -C, --control-directory The directory for sockets and control data -V, --version Show the version number and exit.
Created attachment 366427 [details] [review] main: Remove unnecessary HAVE_LOCALE_H checks
Review of attachment 366427 [details] [review]: Thanks, looks fine.
Attachment 366427 [details] pushed as 2df1366 - main: Remove unnecessary HAVE_LOCALE_H checks