GNOME Bugzilla – Bug 791007
Adjust meson options to match best practices
Last modified: 2017-11-30 12:31:26 UTC
See patches and https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting.
Created attachment 364643 [details] [review] build: Remove 'enable' prefix from option names Meson options are typed, so the prefix isn't necessary, and indeed looks odd when used to disable the option: -Denable_foo=false Also replace underscores with dashes, which is the preferred meson style.
Created attachment 364644 [details] [review] build: Stop detecting features automatically Auto-detect options add some convenience for platforms where a particular feature isn't available - systemd on non-Linux OS comes to mind - but the downside is that it is easy to accidentally build without a desired feature. We consider the latter much more serious nowadays, so turn our auto-detect options into regular boolean options.
Review of attachment 364643 [details] [review]: lgtm
Review of attachment 364644 [details] [review]: lgtm
Attachment 364643 [details] pushed as 10c602f - build: Remove 'enable' prefix from option names Attachment 364644 [details] pushed as ca367e4 - build: Stop detecting features automatically