After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789946 - FLAC CD imports create corrupt FLAC files
FLAC CD imports create corrupt FLAC files
Status: RESOLVED DUPLICATE of bug 785558
Product: rhythmbox
Classification: Other
Component: Importing
3.4.x
Other Linux
: Normal critical
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-05 22:43 UTC by Justin W. Flory
Modified: 2017-11-06 22:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
MusicBrainz Picard import log (1.76 KB, text/plain)
2017-11-05 22:43 UTC, Justin W. Flory
Details
ffmpeg import log (1.37 KB, text/plain)
2017-11-05 22:44 UTC, Justin W. Flory
Details
FLAC import log (299 bytes, text/plain)
2017-11-05 22:44 UTC, Justin W. Flory
Details

Description Justin W. Flory 2017-11-05 22:43:28 UTC
Created attachment 363027 [details]
MusicBrainz Picard import log

## SUMMARY

When Rhythmbox 3.4.1 imports CDs as FLAC, it imports corrupt FLAC files.


## EXPLANATION

I've noticed this since August 2017. Whenever I try ripping a CD, it creates FLAC files with (I think) broken headers. For example, when I try loading the FLAC files into any application, they give an error for the files.

I tried OGG and it worked as expected. The only file format that seems to be broken is the FLAC imports. Rhythmbox may be writing an invalid sync code or frame header.


## EXPECTED BEHAVIOR

1. Insert CD, set import preference in RB to FLAC
2. Import CD
3. Open file with MusicBrainz Picard, ffmpeg, or FLAC
4. Work with file normally, either by writing metadata, converting, or playing the file


## ACTUAL BEHAVIOR


1. Insert CD, set import preference in RB to FLAC
2. Import CD
3. Open file with MusicBrainz Picard, ffmpeg, or FLAC
4. Receive error messages that files are corrupt


## APPENDIX

Attached to this bug are three log files. For one file that I imported from a CD (filename=03 Conta Costa.flac), I attached the logs from MusicBrainz Picard, ffmpeg, and FLAC itself.
Comment 1 Justin W. Flory 2017-11-05 22:44:01 UTC
Created attachment 363028 [details]
ffmpeg import log
Comment 2 Justin W. Flory 2017-11-05 22:44:22 UTC
Created attachment 363029 [details]
FLAC import log
Comment 3 gkrithi8 2017-11-05 23:31:04 UTC
Reproducible in git master.

Should be the same as bug 745992.
Comment 4 Justin W. Flory 2017-11-05 23:36:31 UTC
@gkrithi8 I forgot bug 745992 was mine too. I only started having this issue recently (in the last six to eight months, maybe). I was definitely able to import FLAC files later, after I filed bug 745992 in 2015. I think these are separate issues. I probably need to retest that old issue anyways.
Comment 5 gkrithi8 2017-11-06 19:46:38 UTC
Seems to be an issue with gst-plugins-good : audioparsers element. ( libgstaudioparsers.so )

Files: gstflacparse.{h,c}
Commit: https://github.com/GStreamer/gst-plugins-good/commit/adeee44b

Reverting the commit and building loads metadata fine.
Comment 6 gkrithi8 2017-11-06 19:51:22 UTC
gstreamer bug: https://bugzilla.gnome.org/show_bug.cgi?id=727802

Please mark bug dependency.
Comment 7 Jonathan Matthew 2017-11-06 20:55:11 UTC
Bug dependencies don't do anything.  Is there something to fix in rhythmbox here?
Comment 8 gkrithi8 2017-11-06 22:17:18 UTC
(In reply to Jonathan Matthew from comment #7)
> Bug dependencies don't do anything.  Is there something to fix in rhythmbox
> here?

No.
Comment 9 gkrithi8 2017-11-06 22:17:30 UTC
More recent gstreamer bug: https://bugzilla.gnome.org/show_bug.cgi?id=785558
Comment 10 Philipp Wolfer 2017-11-06 22:20:03 UTC
The currently open bug in gstreamer is https://bugzilla.gnome.org/show_bug.cgi?id=785558

See also the comment by Phillip Wood of considering to use flacenc directly for Sound Juicer until this is resolved. Might be an option for Rhythmbox, too, if you decide this should be fixed independently of gstreamer.
Comment 11 Jonathan Matthew 2017-11-06 22:52:59 UTC
(In reply to Philipp Wolfer from comment #10)
> The currently open bug in gstreamer is
> https://bugzilla.gnome.org/show_bug.cgi?id=785558
> 
> See also the comment by Phillip Wood of considering to use flacenc directly
> for Sound Juicer until this is resolved. Might be an option for Rhythmbox,
> too, if you decide this should be fixed independently of gstreamer.

no, I'm not going to do that.

*** This bug has been marked as a duplicate of bug 785558 ***