GNOME Bugzilla – Bug 789723
[PATCH] gdbus-codegen: Call abspath() earlier
Last modified: 2017-11-06 11:59:03 UTC
Created attachment 362651 [details] [review] [PATCH] gdbus-codegen: Call abspath() earlier The previous change from https://bugzilla.gnome.org/show_bug.cgi?id=786785 didn't actually work (for me at least) in the `/bin/gdbus-codegen` case as the relative `/bin/../share` path works, but then `os.path.abspath()` breaks it (as it's not doing `realpath()`, and let's not go there). Fix this by doing the `abspath` first. Downstream: https://bugzilla.redhat.com/show_bug.cgi?id=1507661
Review of attachment 362651 [details] [review]: Sure.
Comment on attachment 362651 [details] [review] [PATCH] gdbus-codegen: Call abspath() earlier Pushed to master as: commit cb8bfa758fd14794ffeb9cf62fe2a51886b5a6ac (HEAD -> master, origin/master, origin/HEAD) Author: Colin Walters <walters@verbum.org> Date: Tue Oct 31 12:51:09 2017 -0400 gdbus-codegen: Call abspath() earlier The previous change from https://bugzilla.gnome.org/show_bug.cgi?id=786785 didn't actually work (for me at least) in the `/bin/gdbus-codegen` case as the relative `/bin/../share` path works, but then `os.path.abspath()` breaks it (as it's not doing `realpath()`, and let's not go there). Fix this by doing the `abspath` first. Downstream: https://bugzilla.redhat.com/show_bug.cgi?id=1507661 https://bugzilla.gnome.org/show_bug.cgi?id=789723 gio/gdbus-2.0/codegen/gdbus-codegen.in | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)