After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788111 - Non-HTML (plain text, images) files saved as RFC822 messages
Non-HTML (plain text, images) files saved as RFC822 messages
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-25 01:50 UTC by Michael Gratton
Modified: 2017-09-25 13:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Example saved plain text file (2.30 KB, patch)
2017-09-25 01:50 UTC, Michael Gratton 		none Details | Review

Description Michael Gratton 2017-09-25 01:50:17 UTC 
Created attachment 360329 [details] [review]
Example saved plain text file

In 3.26.0 saving a text/plain page via the "Save Page As..." context menu item or via Ctrl+S saves the file as a MIME-encoded RFC 822 message containing HTML wrappers around the plain text content.

E.g. saving https://bug783882.bugzilla-attachments.gnome.org/attachment.cgi?id=357339 to disk results in the attached file.
Comment 1 Michael Catanzaro 2017-09-25 01:57:17 UTC 
I can't reproduce this. :/
Comment 2 Michael Gratton 2017-09-25 02:01:07 UTC 
Huh, weird. This is on an up-to-date Ubuntu Artful install: Ephy 3.26.0 & WebkitGTK+ 2.18.0.
Comment 3 Michael Catanzaro 2017-09-25 02:24:23 UTC 
Oh, I can reproduce it with master. I was testing with 3.24, sorry.

It's surely a regression from https://git.gnome.org/browse/epiphany/commit/?id=77626e20a6e4c312761e7f75184e26ae17a65552.
Comment 5 Michael Gratton 2017-09-25 02:51:19 UTC 
Cheers. I just tried saving an image, that also gets saved as MHTML, so updating the summary.

The Bug 785298 version would would fine if the expression also check if the context type of the main resource is not "text/html", so the else block is only ever executed if the main resource is actually a web page?
Comment 6 Michael Catanzaro 2017-09-25 13:19:18 UTC 
(In reply to Michael Gratton from comment #5) 
> The Bug 785298 version would would fine if the expression also check if the
> context type of the main resource is not "text/html", so the else block is
> only ever executed if the main resource is actually a web page?

I think so, yes.