GNOME Bugzilla – Bug 786885
Add explanatory tooltip to emoji icon
Last modified: 2017-09-01 21:28:58 UTC
The secondary icon is set to a smile emoji, and clicking it shows the emoji entry popover. It'd be good to set a tooltip on the icon to clarify what it'll do if clicked. Also, shouldn't set_show_emoji_icon() unset the icon when FALSE? Currently it seems to be a one-way change in reality: https://git.gnome.org/browse/gtk+/tree/gtk/gtkentry.c?h=gtk-3-22#n11067 However, unsetting the tooltip will run into https://bugzilla.gnome.org/show_bug.cgi?id=785672 unless worked around.
(In reply to Daniel Boles from comment #0) > However, unsetting the tooltip will run into > https://bugzilla.gnome.org/show_bug.cgi?id=785672 unless worked around. other way round: unsetting the entry tooltip will hide those of the icons, but setting icon tooltips doesn't harm the main one anymore
Created attachment 358624 [details] [review] Entry: Set explanatory tooltip on emoji icon
Review of attachment 358624 [details] [review]: Since https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=669e8c4de578f174a48f39f4a1a5bc1bfaf758b5 this should also unset the tooltip-text for the icon.
+ "Emoji Chooser"); This should be translatable, of course.
Of course! Thanks for the eagle eye, as always. :) I've got an updated patch, with some nice cleanups we can apply before it. In the meantime, I wasn't sure about the tooltip - whether to say Emoji Emoji Chooser Emoji Picker and also whether to capitalise the 2nd word (though I think this is correct). So if anyone has any preferred text to use, I'd appreciate suggestions.
Created attachment 358677 [details] [review] Entry: Set tooltip text on icon for emoji chooser
I would suggest to make the tooltip the same as the menitem: "Insert Emoji"
Created attachment 358751 [details] [review] Entry: Set tooltip text on icon for emoji chooser Oh yeah, of course.
Attachment 358751 [details] pushed as 7a3548e - Entry: Set tooltip text on icon for emoji chooser