GNOME Bugzilla – Bug 786276
Correct tooltips for partition size entry
Last modified: 2017-08-15 20:16:47 UTC
The suffix ", in megabytes" for the partition dialog and new image dialog needs to be removed.
Created attachment 357549 [details] [review] Correct tooltips for partition size entry The tooltip was always claiming to have MB as unit while the unit could be changed to any other. Mentioning the unit is removed. The tooltip markup text is deleted instead of updated because it's not in use.
Review of attachment 357549 [details] [review]: Thanks, looks ok and it is ok to push before string freeze. ::: src/disks/ui/new-disk-image-dialog.ui @@ +84,3 @@ <property name="can_focus">True</property> <property name="has_tooltip">True</property> + <property name="tooltip_text" translatable="yes">The size of the partition to create</property> Not sure that it is actually correct to talk about partition size, shouldn't this rather be image size? But this also affects the label text, not only the tooltip...
Created attachment 357623 [details] [review] Correct text for partition size entry Ah, thanks. So I think it's better to remove this mistake now while changing the string anyway.
Review of attachment 357623 [details] [review]: Ok
Btw we are in string change announcement period, so you should announce the changes to gnome-i18n@ and gnome-doc-list@: https://wiki.gnome.org/ReleasePlanning/Freezes#String_Change_Announcement_Period
Thanks, done.