After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786276 - Correct tooltips for partition size entry
Correct tooltips for partition size entry
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: Disks UI
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-14 12:24 UTC by Kai Lüke
Modified: 2017-08-15 20:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Correct tooltips for partition size entry (3.46 KB, patch)
2017-08-14 12:26 UTC, Kai Lüke
none Details | Review
Correct text for partition size entry (4.10 KB, patch)
2017-08-15 11:59 UTC, Kai Lüke
committed Details | Review

Description Kai Lüke 2017-08-14 12:24:57 UTC
The suffix ", in megabytes" for the partition dialog and new image dialog needs to be removed.
Comment 1 Kai Lüke 2017-08-14 12:26:25 UTC
Created attachment 357549 [details] [review]
Correct tooltips for partition size entry

The tooltip was always claiming to have MB as unit
while the unit could be changed to any other.

Mentioning the unit is removed. The tooltip markup text
is deleted instead of updated because it's not in use.
Comment 2 Ondrej Holy 2017-08-15 11:43:50 UTC
Review of attachment 357549 [details] [review]:

Thanks, looks ok and it is ok to push before string freeze.

::: src/disks/ui/new-disk-image-dialog.ui
@@ +84,3 @@
                 <property name="can_focus">True</property>
                 <property name="has_tooltip">True</property>
+                <property name="tooltip_text" translatable="yes">The size of the partition to create</property>

Not sure that it is actually correct to talk about partition size, shouldn't this rather be image size? But this also affects the label text, not only the tooltip...
Comment 3 Kai Lüke 2017-08-15 11:59:37 UTC
Created attachment 357623 [details] [review]
Correct text for partition size entry

Ah, thanks. So I think it's better to remove this mistake now while changing the string anyway.
Comment 4 Ondrej Holy 2017-08-15 13:00:40 UTC
Review of attachment 357623 [details] [review]:

Ok
Comment 5 Ondrej Holy 2017-08-15 13:06:26 UTC
Btw we are in string change announcement period, so you should announce the changes to gnome-i18n@ and gnome-doc-list@:
https://wiki.gnome.org/ReleasePlanning/Freezes#String_Change_Announcement_Period
Comment 6 Kai Lüke 2017-08-15 20:16:47 UTC
Thanks, done.