GNOME Bugzilla – Bug 785558
Broken metdata in ripped FLAC files
Last modified: 2018-03-16 10:03:43 UTC
Ripping a CD as FLAC results in files with broken metadata block. I can playback the files, but software reading the metadata fails (see errors below). Arch Linux Gnome 3.24 Sound Juicer 3.24 gstreamer 1.12.2 flac 1.3.2 Here are various error messages I get: Tracker reportes in journal: tracker-extract[1231]: gst_mini_object_ref: assertion 'mini_object != NULL' failed Running flac -wst on a file: Disc 1 - 01 - Verboten.flac: *** Got error code 0:FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC Disc 1 - 01 - Verboten.flac: ERROR while decoding data state = FLAC__STREAM_DECODER_ABORTED Mutagen (used from inside Picard) shows: E: 14:31:01 Traceback (most recent call last):
+ Trace 237724
result = self.func()
return self._load(filename)
file = self._File(encode_filename(filename))
self.load(*args, **kwargs)
return func(*args, **kwargs)
return func(self, h, *args, **kwargs)
while self.__read_metadata_block(fileobj):
block = block_type(fileobj)
self.load(data, *args, **kwargs)
super(VCFLACDict, self).load(data, errors=errors, framing=framing)
string = fileobj.read(length).decode('utf-8', errors)
size, len(data))) error: file said 301989888 bytes, read 25005107 bytes
I will try to provide a sample file, but I will be travelling the next two weeks. Also I have seen the somehow similar issue https://bugzilla.gnome.org/show_bug.cgi?id=784092 , but for me all the files showed the same kind of corruption
Same here. I do not recieve any metadata when ripping to flac. All is 'unknown' (artist, album, title...). I can provide a sample file if needed, but I don't know if that would be ok legally.
Here is a sample FLAC file with broken metadata I just ripped with sound-juicer: https://drive.google.com/open?id=0B4YQhIuWC-gcakRIYy1xVUhyNDQ Installed packages that might be relevant: sound-juicer 3.24.0+2+gb8380d2d-1 gstreamer 1.12.2-1 flac 1.3.2-1 The song in the file is "15 Ghosts II" by Nine Inch Nails and is licensed under Creative Commons BY-NC-SA
Downgrading to gstreamer 1.10 does not show this issue. This looks like a gstreamer issue unrelated to sound-juicer.
Upgraded to gstreamer 1.12.3, issue still present.
This is definitely a problem for me. On Fedora 26 with: sound-juicer-3.24.0-1.fc26.x86_64 gstreamer1-1.12.2-1.fc26.x86_64 flac-libs-1.3.2-2.fc26.x86_64 Not a single file I encode appears to pass a "flac -t". The current batch I'm looking at is 559 tracks from 28 different discs. The files also fail to decode with "flac -d" and will sometimes fail with other tools (e.g. "ffmpeg -i foo.flac foo.mp3"). I can play the files back with gstreamer-based applications, and if I run through decode and encode again I can produce usable files (though with an empty VORBIS_COMMENT block) filesrc location=foo.flac ! decodebin ! flacenc ! filesink location=foo_new.flac Though some small number of those files seem to end up with bad MD5 signatures in the STREAMINFO block. Since I have only recently been having trouble I checked some previous encoded files, and all of them test okay. I'm not sure exactly what version I was using at the time, but it may have been Fedora 25 (date on the newest files is May). Interestingly none of these files actually set the MD5 signature in STREAMINFO; a flac -t produces the follow message: WARNING, cannot check MD5 signature since it was unset in the STREAMINFO
I think this is related to changes in gst-plugins-good commit adeee44b07 - flacparse: fix header rewriting being ignored. Ironically that was supposed to fix a bug reported in sound-juicer that the MD5 was not written properly. Reverting that commit fixes the tags in the flac file but leaves the MD5 broken. The relavent gstreamer bug is https://bugzilla.gnome.org/show_bug.cgi?id=727802
Seems to be a regression, marking as blocker.
Hello guys, currently running Arch linux, gstreamer 1.12.3-1 rhythmbox 3.4.2+4+ge123ad533-1 flac 1.3.2-1 Ripping a CD still gives flac files without any artist/title/album. I am currently waiting to rip my cd collection until this is resolved. Thank you very much!
Same issue on Ubuntu 17.10 (gstreamer 1.12.3 / sound-juicer 3.24.0) All files seem to be corrupt one way or another after ripping. ---- Not sure if it's relevant, but when starting sound-juicer with --gst-debug-level=2 it shows the following warnings: 0:00:12.210857340 30017 0x555a40f02140 WARN audio-resampler audio-resampler.c:274:convert_taps_gint16_c: can't find exact taps 0:00:12.214416926 30017 0x555a40fd9ca0 WARN gio_base_sink gstgiobasesink.c:217:gst_gio_base_sink_event:<file_sink> ignored SEGMENT event in time format
We should probably revert the offending commit for the time being until someone has time to look at what goes wrong with it.
(In reply to Tim-Philipp Müller from comment #11) > We should probably revert the offending commit for the time being until > someone has time to look at what goes wrong with it. Yes, that would avoid the worst effects, but the files created would still not have a valid MD5. For sound-juicer I'm considering special casing flac encoding to just use flacenc directly until this is resolved. We do this for mp3 files already as encodebin creates vbr files without an xing header
[Rhythmbox bug]: https://bugzilla.gnome.org/show_bug.cgi?id=789946
*** Bug 789946 has been marked as a duplicate of this bug. ***
See commit by Tim-Philipp Müller: https://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=d4c04cb079661948ea520d55da2cc77e5d7ae295
Great ! Should be available in gst-plugins-good 1.12.4, when ready.
1.12.4 release is now available. https://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?h=1.12&id=224938300a3b0fd8263422c3548576ac939032e5
Thanks. Patch fixes it for me.
*** Bug 794165 has been marked as a duplicate of this bug. ***