After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785423 - Missing nullable annotation for gtk_bin_get_child
Missing nullable annotation for gtk_bin_get_child
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Language Bindings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-07-26 02:18 UTC by Iñaki García Etxebarria
Modified: 2017-08-03 19:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch fixing the introspection data (806 bytes, patch)
2017-07-26 02:18 UTC, Iñaki García Etxebarria 		committed Details | Review

Description Iñaki García Etxebarria 2017-07-26 02:18:20 UTC 
Created attachment 356391 [details] [review]
Patch fixing the introspection data

gtk_bin_get_child can return NULL, but it is not properly annotated as such.
Comment 1 Daniel Boles 2017-08-03 19:19:48 UTC 
Review of attachment 356391 [details] [review]:

Makes perfect sense.
Comment 2 Daniel Boles 2017-08-03 19:21:14 UTC 
Review of attachment 356391 [details] [review]:

::: gtk/gtkbin.c
@@ +200,3 @@
  * added, so you do not need to unref it.
  *
+ * Returns: (transfer none) (nullable): pointer to child of the #GtkBin

As per https://bugzilla.gnome.org/show_bug.cgi?id=781246#c2 this should really have an additional clause, like ", or %NULL if there is no child".