After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784974 - Service file generation from a template
Service file generation from a template
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: general
3.25.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
Depends on:
Blocks: 784975
 
 
Reported: 2017-07-15 09:09 UTC by Iñigo Martínez
Modified: 2017-07-17 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Created template file for service file (1.71 KB, patch)
2017-07-15 09:09 UTC, Iñigo Martínez 		none Details | Review
Created template file for service file (1.91 KB, patch)
2017-07-15 14:20 UTC, Kai Lüke 		committed Details | Review

Description Iñigo Martínez 2017-07-15 09:09:28 UTC 
Created attachment 355669 [details] [review]
Created template file for service file

Currently service file is created on the fly by copying its contents from the Makefile build file. This patch removes those contents from the Makefile, that should only have build information,  storing them in a template file.
Comment 1 Kai Lüke 2017-07-15 13:21:47 UTC 
make distcheck fails, the sed rule for org.gnome.DiskUtility.service somehow needs a reference to the src directory.
Comment 2 Kai Lüke 2017-07-15 14:20:24 UTC 
Created attachment 355686 [details] [review]
Created template file for service file

The file was just missing, I have updated the patch to include dbusservice_in_files in EXTRA_DIST.
Comment 3 Iñigo Martínez 2017-07-15 14:42:41 UTC 
True! I have forgotten to add it to extra files. I was focused on meson port, sorry!
Comment 4 Kai Lüke 2017-07-17 14:57:48 UTC 
Thanks again :)