GNOME Bugzilla – Bug 784242
gnome-contacts fails to build with vala 0.36
Last modified: 2017-07-17 23:38:54 UTC
Created attachment 354554 [details] build log gnome-contacts 3.22.1 fails to build from source on Ubuntu 17.10 Alpha with vala 0.36. (vala 0.36 was released alongside GNOME 3.22) I cherry-picked https://git.gnome.org/browse/gnome-contacts/commit/?id=2ba6e38 but that wasn't sufficient. I'm attaching a build log made with that patch applied.
Indeed, seems like it's due to Folks' VAPI's not being handled well by valac 0.36 (mentioned by bug 784240). I'm keeping this bug open in case we might want to look for an intermediate solution ourselves (e.g. temporarily holding a patched version of the vapi's ourselves).
I was able to build gnome-contacts successfully after patching folks with the folks commit https://git.gnome.org/browse/folks/commit/?id=ddc7e71c5d0d113a1b46e2a89986f5a9c3ab8374 Then I needed to patch gnome-contacts with these two commits: https://git.gnome.org/browse/gnome-contacts/commit/?id=2ba6e38 https://git.gnome.org/browse/gnome-contacts/commit/?id=7b9d178
Created attachment 354914 [details] [review] build: Bump folks requirement So we don't hit https://bugzilla.gnome.org/show_bug.cgi?id=784240
gnome-contacts master built fine against the new folks release.
Thanks! Committed as 7a9001b056b4fb1d00375e7b2adeda9b7cf93c90