After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783640 - Rename "Font Viewer" to "Fonts"
Rename "Font Viewer" to "Fonts"
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on: 783613
Blocks:
 
 
Reported: 2017-06-10 19:07 UTC by Jeremy Bicha
Modified: 2017-07-31 11:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rename "Font Viewer" to "Fonts" (6.03 KB, patch)
2017-06-10 19:07 UTC, Jeremy Bicha 		none Details | Review
AppData: add Provides for old .desktop name (1.54 KB, patch)
2017-07-14 19:31 UTC, Jeremy Bicha 		none Details | Review
Rename "Font Viewer" to "Fonts" (2.44 KB, patch)
2017-07-31 11:24 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2017-06-10 19:07:23 UTC 
to match the naming convention used by other GNOME core apps
Comment 1 Jeremy Bicha 2017-06-10 19:07:26 UTC 
Created attachment 353544 [details] [review]
Rename "Font Viewer" to "Fonts"
Comment 2 Cosimo Cecchi 2017-07-11 07:16:38 UTC 
Allan, I would like to go ahead with this for 3.26. Any thoughts/objections?
Comment 3 Jeremy Bicha 2017-07-14 19:31:11 UTC 
Created attachment 355626 [details] [review]
AppData: add Provides for old .desktop name

See https://bugzilla.gnome.org/show_bug.cgi?id=784588

I can squash this into the previous commit if you want or keep it separate
Comment 4 Cosimo Cecchi 2017-07-31 10:19:56 UTC 
Jeremy, I would like to go ahead with the rename, but I am not sure that I would also rename the binary, desktop file and the application ID. Can't you just change the display name in the desktop file instead?
Comment 5 Jeremy Bicha 2017-07-31 11:24:26 UTC 
Created attachment 356636 [details] [review]
Rename "Font Viewer" to "Fonts"

Updated the patch to only change the user-visible parts without changing filenames.

Thanks.
Comment 6 Cosimo Cecchi 2017-07-31 11:32:08 UTC 
Review of attachment 356636 [details] [review]:

LGTM
Comment 7 Cosimo Cecchi 2017-07-31 11:32:38 UTC 
Comment on attachment 355626 [details] [review]
AppData: add Provides for old .desktop name

Should not be needed anymore.
Comment 8 Jeremy Bicha 2017-07-31 11:43:21 UTC 
Attachment 356636 [details] pushed as 39af921 - Rename "Font Viewer" to "Fonts"