After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783078 - Password strings are untranslated
Password strings are untranslated
Status: RESOLVED FIXED
Product: zenity
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Zenity Maintainers
Zenity Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-25 10:04 UTC by Alfredo Vicente
Modified: 2017-12-04 18:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
password: Replace N_() with regular _() (1.03 KB, patch)
2017-10-30 00:53 UTC, Piotr Drąg
committed Details | Review

Description Alfredo Vicente 2017-05-25 10:04:54 UTC
There are problems with the translations in some strings. It seems that the .po file is right.
I noticed that the string in password.c

73  gchar *title_text = N_("Type your password");
74
75  if(password_data->username)
76    title_text = N_("Type your username and password"); 

with the prefix N_ doesn't translate, but if I change it to:

73  gchar *title_text = _("Type your password");
74
75  if(password_data->username)
76    title_text = _("Type your username and password"); 

the translation is properly done. I don't know if there is any other string like this. I checked it with ca@valencia and es_ES and it works if I change the N_.
Comment 1 Arx Cruz 2017-05-26 12:32:29 UTC
This is weird, I'm not a specialist in I18n so I would like to hear what Piotr Drag have to say about it.
Comment 2 Piotr Drąg 2017-05-26 13:35:51 UTC
I’m not sure what happens here. Other strings marked with N_, in about.c and option.c, are showing up translated. Maybe these two shouldn’t use N_?

Here is some info on it: https://developer.gnome.org/glib/stable/glib-I18N.html#N-:CAPS
Comment 3 Piotr Drąg 2017-05-26 13:36:49 UTC
I’ve found that this code was added in bug #712616.
Comment 4 Piotr Drąg 2017-10-30 00:53:02 UTC
Created attachment 362501 [details] [review]
password: Replace N_() with regular _()

Alfredo’s solution in a patch form.
Comment 5 Piotr Drąg 2017-11-26 20:18:44 UTC
I compiled Zenity with this patch. The strings show up translated, and the dialog works as intended.
Comment 6 Piotr Drąg 2017-12-04 18:15:48 UTC
Comment on attachment 362501 [details] [review]
password: Replace N_() with regular _()

Pushed: https://git.gnome.org/browse/zenity/commit/?id=ab9f2e70e4914a2ca943c2584696ea06da397f11