GNOME Bugzilla – Bug 781587
Add error-message, error-for, details, and details-for relation types
Last modified: 2017-05-24 10:17:42 UTC
This is to support a new ARIA feature. https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaErrorMessage
(Combining bugs so I can do just one patch) The opening report is for aria-errormessage. There is a similar-in-nature aria-details feature which was also introduced in ARIA 1.1 and which also requires new relation types, namely details and details-for: https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaDetails
*** Bug 781591 has been marked as a duplicate of this bug. ***
Created attachment 352426 [details] [review] proposed patch Please review. Thanks!
Review of attachment 352426 [details] [review]: LGTM. Just a nitpick about a English word from a non-native speaker. Is "Inverse" the correct word to relate the _BY and _FOR relations about the same info? Seems to suggest that are the opposite, when it is more like one being the mirror or the other. In any case, it is just a nitpick. If you need more that 5 seconds to think about a better word, just forget my comment.
(In reply to Alejandro Piñeiro Iglesias (IRC: infapi00) from comment #4) > Review of attachment 352426 [details] [review] [review]: > > LGTM. Just a nitpick about a English word from a non-native speaker. Is > "Inverse" the correct word to relate the _BY and _FOR relations about the > same info? Seems to suggest that are the opposite, when it is more like one > being the mirror or the other. > > In any case, it is just a nitpick. If you need more that 5 seconds to think > about a better word, just forget my comment. "Inverse" was already in there for ATK_RELATION_EMBEDDED_BY, so I used it to be consistent with that. The ATSPI2 docs use "reciprocal" (and so that is what I used in my patch for it). The Core AAM (ARIA mapping spec) uses "reverse". My personal preference of the three is "reciprocal," so how 'bout I use it and also change ATK_RELATION_EMBEDDED_BY?
Created attachment 352481 [details] [review] proposed patch Same patch as before, but uses "reciprocal" instead of "inverse," and also changes "inverse" to "reciprocal" for ATK_RELATION_EMBEDDED_BY.
Review of attachment 352481 [details] [review]: LGTM. Thanks!
Comment on attachment 352481 [details] [review] proposed patch Thanks for the reviews. Committed. https://git.gnome.org/browse/atk/commit/?id=45716bc