GNOME Bugzilla – Bug 781422
translate_wm_button_layout_to_gtk() is licensed under the GPL
Last modified: 2017-05-08 21:53:17 UTC
VMware legal unearthed a GPL licensed file during our open source license validation steps for shipping a product with Gtk+ 3.x for the first time: gtk+/gdk/wayland/wm-button-layout-translation.c. It appears to only export the translate_wm_button_layout_to_gtk() symbol, but does so under the GPLv2: <<< /* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*- * * Copyright (C) 2014 Red Hat, Inc. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, see <http://www.gnu.org/licenses/>. * * Author: Florian Müllner <fmuellner@gnome.org> */ #ifndef __WM_BUTTON_LAYOUT_TRANSLATION__ #define __WM_BUTTON_LAYOUT_TRANSLATION__ void translate_wm_button_layout_to_gtk (char *layout); #endif >>> We aren't *incredibly* worried about this at the moment, as we cannot currently enable the wayland backend for our shipped version of the library anyway, but it will come up as an issue if and when we get there. Others may be much more worried...
Florian, I think this is your code - willing to relicense it ?
Created attachment 350245 [details] [review] gdk: Relicense translate_wm_button_layout_to_gtk() It is generally a good idea to license individual files under the same terms as the project license (in particular when the mismatch boils down to having copied the wrong license header), so relicense the code under the LGPL.
Review of attachment 350245 [details] [review]: thanks. can you push this to gtk-3-22 as well, please ?