GNOME Bugzilla – Bug 779412
gjs 1.47.91 configure fails with Fedora's mozjs38
Last modified: 2017-03-01 22:03:39 UTC
gjs 1.47.91 configure has a new check to detect whether mozjs was built with the intl api. For this test, it tries to execute a script with the standalone interpreter, /usr/bin/js or /usr/bin/js38. However, Fedora's mozjs38 only includes the library and not the standalone interpreter, making it impossible to build gjs. Would it possible to drop this configure check, please?
Sure. I have recently learned from upstream that the standalone js interpreter is not really meant to be distributed in the first place. So I can definitely remove the check. I really would like to check this at build time, but I don't see any other way. Do you?
Created attachment 346992 [details] [review] tests: Test explicitly for Intl API This should at least make it more clear what is going on if these tests fail, and what the fix is: compile the Intl API into SpiderMonkey. A build-time check would be preferred, but that is not possible; see bug report.
I reverted the configure check. This patch will hopefully make it more clear what the problem is if you have built mozjs without the Intl API, but unfortunately it's not a configure-time check.
Review of attachment 346992 [details] [review]: Makes sense.
Excellent, thanks!
(In reply to Philip Chimento from comment #1) > Sure. I have recently learned from upstream that the standalone js > interpreter is not really meant to be distributed in the first place. So I > can definitely remove the check. Do you have a reference for not distributing the js binary?
(In reply to Jeremy Bicha from comment #6) > Do you have a reference for not distributing the js binary? From here: https://bugzilla.mozilla.org/show_bug.cgi?id=1339931#c9