After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779253 - Drop "(maximum)" text at the end of sliders
Drop "(maximum)" text at the end of sliders
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: properties
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-02-26 13:39 UTC by Felipe Borges
Modified: 2017-03-30 16:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
i-properties-provider: Drop "(maximum)" text at the end of sliders (1.28 KB, patch)
2017-03-30 15:20 UTC, Julius Härtl 		committed Details | Review

Description Felipe Borges 2017-02-26 13:39:12 UTC 
As suggested in Bug 746478, the "(maximum)" text at the end of each slider in the Properties dialog seems superfluous - it's the end of the slider; this already communicates that it's the maximum.

See the desired output in the following screenshot (right side) https://bug746478.bugzilla-attachments.gnome.org/attachment.cgi?id=299865

This is a 'newcomers' bug.
Comment 1 Julius Härtl 2017-03-30 15:20:10 UTC 
Created attachment 349000 [details] [review]
i-properties-provider: Drop "(maximum)" text at the end of sliders

The "(maximum)" text at the end of each slider in the Properties
dialog is superfluous - it's the end of the slider. This already
communicates that it's the maximum.
Comment 2 Felipe Borges 2017-03-30 16:40:48 UTC 
Review of attachment 349000 [details] [review]:

Sure! lgtm
Comment 3 Felipe Borges 2017-03-30 16:44:29 UTC 
Thanks for your patch!

I see (from your bugzilla account) that this is your first contribution. We would like to have you around to hack with us in Boxes. Most contributors to Boxes hang out on irc.gnome.org, channel #boxes. You are very welcome there!

Attachment 349000 [details] pushed as ce9aa75 - i-properties-provider: Drop "(maximum)" text at the end of sliders