After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777866 - Thumbnail grid - some thumbnails are small
Thumbnail grid - some thumbnails are small
Status: RESOLVED DUPLICATE of bug 690255
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-01-28 11:23 UTC by Allan Day
Modified: 2017-02-23 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (328.28 KB, image/png)
2017-01-28 11:23 UTC, Allan Day
Details

Description Allan Day 2017-01-28 11:23:59 UTC
Created attachment 344452 [details]
screenshot

Running master, some of the thumbnails in the main grid are smaller than the others. The corresponding image files are large and are shown at full size when you open them.

There's a screenshot attached.
Comment 1 Debarshi Ray 2017-01-28 16:14:22 UTC
Incidentally, we were discussing this with Jimmac yesterday during DevConf.

What's happening here is that some other program has generated smaller thumbnails for those files. Earlier that used to be nautilus, but that's no longer the case since bug 686851, so I am not sure who that would be here. There is a bug in glib (https://bugzilla.gnome.org/show_bug.cgi?id=686895#c7) due to which an application can't query for a hi-res thumbnail without falling back to the lo-res one.

Earlier we used to scale up these smaller thumbnails.

Bug 690255 is about these scaled up thumbnails looking bad. There is also bug 740417 about thumbnails of really tiny images looking bad when scaled up. As a result, we don't them zoom them any more.

Fast forward to this day, we now support non-destructive editing. Since we can't reasonably expect the desktop-wide thumbnailers to support serialized GEGL pipelines, we really do need our own custom thumbnailer. That's also what shotwell and darktable do, by the way. That will make the glib bug irrelevant.

Plus, we need to get bug 745375 fixed.
Comment 2 Debarshi Ray 2017-02-23 15:05:18 UTC
We should no longer have small thumbnails unless the source image is really small. See bug 690255

Please remove gnome-photos' thumbnail cache (rm -rf ~/.cache/gnome-photos/thumbnails) before testing.

Some thumbnails might be distorted due to a GEGL bug (see bug bug 779135). We will either have it fixed and released, or worked around in the application in time for GNOME 3.24.

*** This bug has been marked as a duplicate of bug 690255 ***