After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777235 - Pressing back button when searching through a subview, should turn search off and go back.
Pressing back button when searching through a subview, should turn search off...
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.23.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2017-01-13 20:31 UTC by Abhinav Singh
Modified: 2017-01-16 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Hide the search view and search bar, and then go back. (766 bytes, patch)
2017-01-13 20:37 UTC, Abhinav Singh 		committed Details | Review

Description Abhinav Singh 2017-01-13 20:31:16 UTC 
https://bugzilla.gnome.org/show_bug.cgi?id=777127

As discussed in this link,

---
I think the whole interaction model for subviews + search is a bit weird. If you search and you change a view, the search is gone. If you search in a subview (like a specific album view) you can actually sometimes go back and sort of switch views. This is unwanted behaviour imo, it should cancel the search or not be allowed.
---

Solution: Cancel search and go back.
Comment 1 Abhinav Singh 2017-01-13 20:37:44 UTC 
Created attachment 343451 [details] [review]
Hide the search view and search bar, and then go back.
Comment 2 Marinus Schraal 2017-01-14 12:54:17 UTC 
Review of attachment 343451 [details] [review]:

lgtm

as for the commit msg, try to keep it in line with the gnome guidelines and the other commits.

https://wiki.gnome.org/Git/CommitMessages
Comment 3 Marinus Schraal 2017-01-16 09:44:20 UTC 
Rewrote commit message.

Thanks for the patch.