After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776294 - Screenshot buttons cannot be clicked
Screenshot buttons cannot be clicked
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: macOS DMG package
2.8.18
Other Mac OS
: Normal normal
: 2.8
Assigned To: GIMP Bugs
Kristian Rietveld
: 773677 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-12-19 21:12 UTC by Michael
Modified: 2016-12-28 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael 2016-12-19 21:12:03 UTC
None of the buttons in the "File > Create > Screenshot" popup can be clicked. Neither the radio buttons nor the "Help," "Cancel," and "Snap" buttons. OSX can close the window with the top-left (x).

I'm using macOS Sierra v10.12.1
Comment 1 Jehan 2016-12-24 09:55:50 UTC
Hello,

Thanks for reporting.
We'll need to wait for Kris or some other OSX dev to look into this issue, I guess.

> Neither the radio buttons nor the "Help," "Cancel," and "Snap" buttons.

Which buttons are these exactly?
Comment 2 Kristian Rietveld 2016-12-25 14:47:52 UTC
It works for me on my machine with 10.9. Will also try on my 10.11 machine, if it works fine on that machine too it could be an issue with Sierra.
Comment 3 Kristian Rietveld 2016-12-28 14:10:19 UTC
Also works on 10.11. We need to figure out whether this is an issue that only appears on Sierra.

It could be that this is caused by the new tab behavior introduced in Sierra. Perhaps you can try and see what happens if you disable the "Prefer tabs when opening documents:" option under System Preferences > Dock.
Comment 4 Michael 2016-12-28 14:18:45 UTC
Your suspicions were correct. My tab preferences on Sierra had been set to "In Full Screen Only," but after changing it to "Manually," the screenshot dialog works again.
Comment 5 Kristian Rietveld 2016-12-28 14:23:08 UTC
Thanks for the quick reply!

I think the best we can do right now is to disable this behavior for GIMP (GIMP can opt-out from the automatic tab behavior), so GIMP will at least work properly on Sierra. Will be looking into a patch.
Comment 6 Kristian Rietveld 2016-12-28 15:47:11 UTC
I think this should fix it ...

Committed to master and gimp-2-8.


commit 7c35d75bf9e540408eb3a6b835f31d82a49d07b1
Author: Kristian Rietveld <kris@loopnest.org>
Date:   Wed Dec 28 16:12:33 2016 +0100

    Bug 776294 - Screenshot buttons cannot be clicked

    Disable the new "automatic window tabbing" feature introduced on macOS
    Sierra. It breaks GTK+ applications and we would need proper support for
    this in GTK+ if we want to use it.
Comment 7 Kristian Rietveld 2016-12-28 15:47:57 UTC
For now, we have fully disabled automatic window tabbing. I think that we should be respecting the user setting for this in Sierra in the future. Discussion on this feature will take place in bug 776546.
Comment 8 Kristian Rietveld 2016-12-28 15:48:26 UTC
(and actually close the bug, forgot to do this together with the commit message.)
Comment 9 Kristian Rietveld 2016-12-28 15:57:50 UTC
*** Bug 773677 has been marked as a duplicate of this bug. ***