After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774331 - Use Unicode in translatable strings
Use Unicode in translatable strings
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.23.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks: 772263
 
 
Reported: 2016-11-12 16:43 UTC by Piotr Drąg
Modified: 2017-06-27 11:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use Unicode in translatable strings (123.52 KB, patch)
2016-11-12 16:43 UTC, Piotr Drąg
reviewed Details | Review

Description Piotr Drąg 2016-11-12 16:43:17 UTC
Created attachment 339701 [details] [review]
Use Unicode in translatable strings

Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Milan Crha 2016-11-21 10:03:16 UTC
Thanks for a bug report, though, ehm, well, you should ask before doing any such large change. Personally, I dislike "compressed three-dots", they distract the whole view visually for me. There had been a bug report for this filled some time ago already. The unicode letters can be a problem in the XML files, similarly as for example the '<>"' letters are. I do not say they always are, just that they can.

I'm not going to commit this right now, neither the other bug reports about the same (bug #774377, bug #774364, bug #774365).
Comment 2 Milan Crha 2016-11-22 09:39:27 UTC

*** This bug has been marked as a duplicate of bug 774377 ***
Comment 3 Milan Crha 2016-11-23 16:55:07 UTC
There is a typo in the patch, which causes a build break at:
src/calendar/libedata-cal/e-cal-backend-sexp.c:712
Comment 4 Milan Crha 2016-11-23 17:22:45 UTC
See bug #774377 comment #9. By the way, I do not understand why you changed quotes also in the translator comments, in places where the apostrophes were used to distinguish between the text and the part which is described, but as I do not want to waste much time on this I just left it that way.

Disclaimer: I cannot promise I'll follow the rule with unicode letters in the future, not because of my ignorance or a need, but simply because I'll surely forget of it in the couple next months :-/

Created commit 2a75cec in eds master (3.23.3+)
Comment 5 Piotr Drąg 2016-11-24 15:34:42 UTC
(In reply to Milan Crha from comment #3)
> There is a typo in the patch, which causes a build break at:
> src/calendar/libedata-cal/e-cal-backend-sexp.c:712

I'm sorry for that. I see you fixed it before committing.

(In reply to Milan Crha from comment #4)
> See bug #774377 comment #9. By the way, I do not understand why you changed
> quotes also in the translator comments, in places where the apostrophes were
> used to distinguish between the text and the part which is described, but as
> I do not want to waste much time on this I just left it that way.
> 

My thought process was to make it consistent, I think. You could've told me to revert that part. :)

> Disclaimer: I cannot promise I'll follow the rule with unicode letters in
> the future, not because of my ignorance or a need, but simply because I'll
> surely forget of it in the couple next months :-/
> 

I'm okay with fixing it after you before string freezes!

> Created commit 2a75cec in eds master (3.23.3+)

Thank you.
Comment 6 Milan Crha 2017-06-26 07:26:38 UTC
Piotr, thank you for your follow up changes in the newly added translatable strings to use the Unicode variants of the ASCII characters. I do not forget of this effort and even I try to use the Unicode variants, I'm just not used to them, I do not know their codes, thus it means significant effort to get to them with compare to simple one-key-press on the keyboard to get the ASCII variant which can be safely used everywhere. (As an example, when I want to use a Unicode double-quotes, I open one of the .po files and search for it in it.) What I wanted to tell with this note is that I do not ignore the effort on purpose, that's really not my intention.
Comment 7 Piotr Drąg 2017-06-27 11:49:26 UTC
I completely understand. And don’t worry, I don’t mind looking after the changes.