GNOME Bugzilla – Bug 773640
rtspclient unit test failures
Last modified: 2016-11-02 11:37:09 UTC
There are some rtsp-server unit test failures which are new. Two rtspclient tests fail fairly frequently: - test_client_multicast_ignore_transport_specific - test_client_multicast_transport_specific These are new failures apparently. They don't happen everytime, but often enough that they should be easy to reproduce. For me they only happen with 'make check', but not with 'make gst/client.check', why I don't know. Running suite(s): rtspclient 84%: Checks: 13, Failures: 2, Errors: 0 gst/client.c:505:F:general:test_client_multicast_ignore_transport_specific:0: 'str' (RTP/AVP;multicast;destination=233.252.0.1;ttl=1;port=5004-5005;mode="PLAY") is not equal to 'expected_transport' (RTP/AVP;multicast;destination=233.252.0.1;ttl=1;port=5000-5001;mode="PLAY") gst/client.c:494:F:general:test_client_multicast_transport_specific:0: 'code' (461) is not equal to 'GST_RTSP_STS_OK' (200) FAIL gst/client (exit status: 2)
git bisect seems to point towards: commit e5a49efa7ffce2ca2eeefb1a8bad97edfc96649f Author: Sebastian Dröge <sebastian@centricular.com> Date: Tue Sep 6 19:10:21 2016 +0300 rtsp-stream: Bind multicast sockets to ANY as before https://bugzilla.gnome.org/show_bug.cgi?id=766612#c48
> For me they only happen with 'make check', but not > with 'make gst/client.check', why I don't know. It looks like it's a bad interaction between multiple tests running at the same time. Lots of tests use the same ports, so it's possible that the fact that it fails like this is not actually a bug in the patch but simply something that wasn't triggered because of the bug the patch fixes. With 'make -j1 check' it always passes for me. What to do? Fix up tests to use different port numbers perhaps?
Created attachment 338742 [details] [review] tests: try to avoid using the same ports in different tests This seems to help. make torture passes.
commit 9e7cafde5aa75c91836b41296b2e714d8f866f6c Author: Tim-Philipp Müller <tim@centricular.com> Date: Fri Oct 28 18:38:01 2016 +0100 tests: try to avoid using the same ports in different tests Causes problems with client multicast tests otherwise if tests are run in parallel.
picked into 1.8 as well.