After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772942 - Regression: /etc/fstab entries using LABEL= and tagged with x-gvfs-show are no longer shown
Regression: /etc/fstab entries using LABEL= and tagged with x-gvfs-show are n...
Status: RESOLVED DUPLICATE of bug 772867
Product: gvfs
Classification: Core
Component: udisks2 volume monitor
1.30.x
Other Linux
: Normal major
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-14 15:05 UTC by Michael Biebl
Modified: 2016-10-17 06:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Biebl 2016-10-14 15:05:39 UTC
Version: 1.30.1

I have the following entry in /etc/fstab

LABEL=Backup   /mnt/backup ntfs-3g noauto,nofail,user,x-gvfs-show 0 0

It's a removable drive which I want to mount at a fixed location. Users should be able to mount/umount it (user option) and it is marked with x-gvfs-show, so it shows up in nautilus (and can easily be unmounted by the user there).

Since 1.30.1 this is broken. A git bisect finds the following commit which broke this functionality:

commit 4d2562b33c07de1b817da8ba44afe07cac5e66c8
Author: Ondrej Holy <oholy@redhat.com>
Date:   Mon Sep 26 15:12:47 2016 +0200

    udisks2: Use device path to match mount points also
    
    Mount path is used to match mount points currently, however device
    path should be used also in order to be sure it is really corresponding
    mount point. Same mount path can be used for multiple mount entries
    (it is also used e.g. for autofs).
    
    $ mount | grep /media/test
    systemd-1 on /media/test type autofs ...
    localhost:/home/oholy on /media/test type nfs4 ...
    
    https://bugzilla.gnome.org/show_bug.cgi?id=771740

Reverting this commit fixes the issue.
Comment 1 Michael Biebl 2016-10-14 15:09:41 UTC
Is it possible that gvfs get's confused because I use a LABEL?
mount shows:

/dev/sdb1 on /mnt/backup type fuseblk (rw,nosuid,nodev,noexec,relatime,user_id=0,group_id=0,allow_other,blksize=4096,user)
Comment 2 Michael Biebl 2016-10-14 17:31:48 UTC
Using /dev/sdb1 instead of LABEL= makes the mount point show up again. So it's indeed a problem of LABEL=, UUID= etc not being resolved to the underlying device.
Comment 3 wooque 2016-10-14 17:46:24 UTC
Similar issue is affecting me after gvfs update 1.30.0 > 1.30.1.

Thunar is showing in sidebar partition with LABEL= as unmounted and they are not, also when I click on them Thunar shows error as it cannot mount already mounted partition.

I also found out that it broke after same commit.
Comment 4 wooque 2016-10-14 18:25:50 UTC
Check added in commit 4d2562b33c07de1b817da8ba44afe07cac5e66c8 is wrong because g_unix_mount_get_device_path is always returning /dev/sdX and g_unix_mount_point_get_device_path is returning LABEL= for partitions listed with LABEL= in /etc/fstab, so check fails
Comment 5 Ondrej Holy 2016-10-17 06:41:13 UTC
Thanks for your bug report! I've already reverted the patches causing those issues and made an another release. I am sorry for the inconvenience...

*** This bug has been marked as a duplicate of bug 772867 ***