After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772879 - Remove cmake non-standard DEBUG option
Remove cmake non-standard DEBUG option
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: build
master
Other Linux
: Normal normal
: 0.12.0
Assigned To: Geary Maintainers
Geary Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-13 16:48 UTC by Gautier Pelloux-Prayer
Modified: 2016-10-22 00:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch proposal v1 (2.77 KB, patch)
2016-10-13 16:50 UTC, Gautier Pelloux-Prayer 		none Details | Review
patch proposal v2 (2.16 KB, patch)
2016-10-13 16:52 UTC, Gautier Pelloux-Prayer 		committed Details | Review

Description Gautier Pelloux-Prayer 2016-10-13 16:48:35 UTC 
Instead of having a custom DEBUG option, we should use standard cmake policies, eg:

> cmake . -DCMAKE_BUILD_TYPE=Debug
Comment 1 Gautier Pelloux-Prayer 2016-10-13 16:50:26 UTC 
Created attachment 337650 [details] [review]
patch proposal v1
Comment 2 Gautier Pelloux-Prayer 2016-10-13 16:52:02 UTC 
Created attachment 337651 [details] [review]
patch proposal v2
Comment 3 Michael Gratton 2016-10-14 00:49:50 UTC 
Pacho, I just CC'ed you on this because of Bug 751556 that you previously reported.

Would this approach help out with your packaging at all?
Comment 4 Pacho Ramos 2016-10-15 09:21:25 UTC 
Well, as it looks to stop appending -g that would help for sure :)
Comment 5 Michael Gratton 2016-10-22 00:18:30 UTC 
Review of attachment 337651 [details] [review]:

Okay, great. This has been pushed to master as commit b54a148. Thanks Gautier!

Pacho, you should now be able to set the appropriate CMake var to get a debug-less build now.