Created attachment 337110 [details] [review]
Make password autofill compatible with Angular forms

Review of attachment 337110 [details] [review]:

LGTM

Review of attachment 337110 [details] [review]:

Please, explain in the commit message why this makes passwords work in Angular forms. Commit now, of course means commit when 2.14.1 is out.

(In reply to Carlos Garcia Campos from comment #3)
> Review of attachment 337110 [details] [review] [review]:
> 
> Please, explain in the commit message why this makes passwords work in
> Angular forms.

I didn't explain it because I have no clue what I've done. :D  I just added the function calls that Dape says Chromium uses.

Created attachment 337461 [details] [review]
Make password autofill compatible with Angular forms

Honestly, I have no clue what I've done here, but it's what Chromium
does when it autofills a form, and it makes an Angular password form
work on one of our internal sites, so it's probably good right?

Wait, I forgot to merge the new api patch in 2.14.1 :-( we will have to wait until 2.14.2, I'm sorry.

Yup, I noticed... not a big deal; it would be great if it's in 2.14.2, though, whenever that is.

It's not really a simple merge anyway, right? Since the bindings are still autogenerated in 2.14, I don't even know how to do it. :)

(In reply to Michael Catanzaro from comment #8)
> It's not really a simple merge anyway, right? Since the bindings are still
> autogenerated in 2.14, I don't even know how to do it. :)

Right, I'll do it, don't worry

Do we still need the 

g_object_set (username_node, "value", username, NULL);
g_object_set (password_node, "value", password, NULL);

I don't think so.

(In reply to Sergio Villar from comment #10)
> Do we still need the 
> 
> g_object_set (username_node, "value", username, NULL);
> g_object_set (password_node, "value", password, NULL);
> 
> I don't think so.

You're right! I've pushed a follow-up.

OK, backported all of this to gnome-3-22 since WebKitGTK+ 2.14.2 is out. Thanks both of you!