GNOME Bugzilla – Bug 771455
tests: use dbus-run-session instead of dbus-launch to run tests
Last modified: 2017-04-26 20:53:49 UTC
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836067 dbus-launch is X11-specific and contains a lot of legacy code to support X11 autolaunching. It should not be part of the Wayland (and/or Mir) future. Use dbus-run-session to run the tests instead.
Created attachment 335599 [details] [review] tests: Use dbus-run-session instead of dbus-launch
Could you make it conditional depending on presence of required executable, otherwise this would be an implicit bump to dbus >= 1.8?
Correct, this requires dbus >= 1.8. Is that an issue? dbus 1.8.0 was released 2014-01-20, i.e. over 2,5 years ago.
I want to keep it buildable without any hassle on Ubuntu Trusty 14.04 which comes with dbus 1.6.18.
The package would be buildable on trusty. You'd just have to skip running the test-suite. I'd rather not make testrunner.sh more complicated then necessary.
Comment on attachment 335599 [details] [review] tests: Use dbus-run-session instead of dbus-launch commit ef50a4259393c64c6beb36dd96e60d185da22fdd Author: Michael Biebl <mbiebl@gmail.com> Date: Thu Sep 15 03:41:00 2016 +0200 tests: Use dbus-run-session instead of dbus-launch dbus-launch is X11-specific and contains a lot of legacy code to support X11 autolaunching. It should not be part of the Wayland future. Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836067