GNOME Bugzilla – Bug 771129
batch rename: segfaults when overwrite mode is enabled
Last modified: 2016-09-20 14:46:29 UTC
Nautilus segfaults when overwrite mode is enabled on batch rename How to reproduce: 1. Select any two files -> rename 2. Now enable overwrite (insert key) and type some text before [Original File Name] Nautilus now segfaults, which it shouldn't.
This is fixed by the patch in Bug 771069
This bug is still present in master. reopening
(In reply to Mohammed Sadiq from comment #2) > This bug is still present in master. > > reopening Are you sure you have your master branch updated? because I can't reproduce this anymore
Here is how I reproduced the bug: 1. Create several files: touch {0000..9999} 2. Select any two files -> Right click -> rename. 3. Place the cursor at beginning (before [Original...]). 4. Enable overwrite -> type something. Nautilus segfaults
*** Bug 771109 has been marked as a duplicate of this bug. ***
Created attachment 335937 [details] [review] batch-rename-dialog: don't multi-thread NautilusDirectory calls Even if late... I just realized neither NautilusDirectory or NautilusFile are thread safe. We were using them from two different threads for checking conflicts, and that was crashing when the internal hash table was modified and accessed from the different threads. The ideal fix would be to make NautilusDirectory and NautilusFile thread safe, but that's a big work. So for now, call the main thread for using them.
Attachment 335937 [details] pushed as 32fc66d - batch-rename-dialog: don't multi-thread NautilusDirectory calls