After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769550 - Test GTK+ patch for keyboard shortcuts for non-English locales (e.g. Russian)
Test GTK+ patch for keyboard shortcuts for non-English locales (e.g. Russian)
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
2.8.18
Other Windows
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
: 795427 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-08-05 11:49 UTC by Siarhei Kuchuk
Modified: 2018-04-21 08:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Video with bug reproduction in Windows GTK+ backend (1.89 MB, video/mp4)
2016-08-06 11:14 UTC, Siarhei Kuchuk
Details

Description Siarhei Kuchuk 2016-08-05 11:49:17 UTC
Hello

Recently there was a long-waiting fix in GTK master for shortcuts for Windows. Users with non-latin keyboard defaults were not able to use any of shortcuts powered with GTK and now they can.

Link to the bugs
https://bugzilla.gnome.org/show_bug.cgi?id=768722
https://bugzilla.gnome.org/show_bug.cgi?id=136280

While fix was commited to master (which is 3.x version) i see that Gimp uses Gtk 2.x. LNR says patch needs additional testing in GIMP and if everything is ok, patch will be commited to 2.x version as well.

Could you please apply patch to your GTK sources and make developer build? Shortcuts support is important for non-english auditory...

If i can help you in any way please tell... i tested fix for 3.x version and it worked (at least for Russian).

Greetings from Belarus.
Comment 1 Jehan 2016-08-05 22:02:50 UTC
I don't have time to test this now. Could someone test if the problem can be reproduced and if the GTK+ patch works?

Feels like something which should be handled before 2.10. Then if we validate this, I guess we should update our GTK+ dependency to whatever version will have the fix.
Comment 2 Michael Natterer 2016-08-06 06:43:01 UTC
Does this only affect windows? Bug 136280 mentions a mac too.
Comment 3 Siarhei Kuchuk 2016-08-06 11:14:23 UTC
Created attachment 332819 [details]
Video with bug reproduction in Windows GTK+ backend
Comment 4 Siarhei Kuchuk 2016-08-06 11:18:08 UTC
>Could someone test if the problem can be reproduced
I added video with bug reproduction

>Does this only affect windows? Bug 136280 mentions a mac too.
I don't have MAC to check, guys who reported in 136280 and 768722 issues with MAC should create other ticket, because there's a different backend for MAC. Patch was created just to address Windows backend issue...
Comment 5 LRN 2016-09-07 17:14:51 UTC
Any progress on this? There's a 2.24.x release coming in a couple of days, you know.
Comment 6 Jehan 2016-11-07 03:02:22 UTC
(In reply to LRN from comment #5)
> Any progress on this? There's a 2.24.x release coming in a couple of days,
> you know.

Unfortunately testing this means for me setting a Windows VM, cross-building all GIMP, and so on. It's not very difficult, but it's still very time-consuming. Also I have space issues because my hard drive is really lacking usable space (and the Windows VM in particular takes crazy amount of space!).

All this to say I would really like to test, and I would at some point if nobody does, but that will have to wait until a day I decide to take on a few bug fixes for Windows. But really I would definitely prefer to not have to do this. If some Windows users and developers could care about their chosen platform, it would be extremely helpful.
This one is easy, and you don't even need to be a developer (just an advanced user who can build GIMP):

1/ build GTK+ and GIMP for Windows;
2/ test if the bug appears;
3/ apply the patch and rebuild GTK+;
4/ test if the bug is fixed;
5/ come back here and tell us your findings.
Comment 7 Siarhei Kuchuk 2016-11-07 10:58:39 UTC
i don't have time at the moment. i've got a job and all efforts are going on crappy javascript missing OOP and angularjs knowledge improvement. i'm like a vegetable on weekends for such staff.
Comment 8 LRN 2016-11-25 17:08:54 UTC
I unilaterally pushed the remaining gtk2 commits to fix bug 569581 and bug 768722.
GIMP will get the new code in due course, when GTK+-2.24.32 is released.
This bug (bug 769550) will be automatically fixed by GIMP pre-release testers, once they update GTK+.
Comment 9 Jehan 2016-11-25 23:23:32 UTC
Awesome. I will update our minimum requirement in our configure file when GTK+ 2.24.32 is released and makes it to Debian testing (which is our base for deciding if a dependency can be set).

Though since it is a Windows-only bug, I wonder if we cannot just set it as minimum requirement for Windows and get over with it.
Comment 10 Jehan 2017-03-29 00:16:05 UTC
You know what. Let's just add the warning already. Even though the fix is not out yet, anyway this is only a configure warning (won't prevent compilation) and the message is already true anyway.

commit b7345863243724ede6a800d2d0a6bbe5c25f63c2
Author: Jehan <jehan@girinstud.io>
Date:   Wed Mar 29 02:06:24 2017 +0200

    Bug 769550: recommend recent GTK+ on Windows with working keyboard...
    
    ... shortcuts for non-English locales (e.g. Russian).
    This will be fixed with GTK+ 2.24.32, which has not been released at
    this time. Yet since it is only a configure warning, there is no harm in
    triggering it already (not a hard requirement, it does not prevent
    compilation).

 configure.ac | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)
Comment 11 Jehan 2018-04-21 08:54:48 UTC
*** Bug 795427 has been marked as a duplicate of this bug. ***