Created attachment 330398 [details] [review]
thumbnail: Always use external gdk-pixbuf thumbnailer

Instead of special-casing gdk-pixbuf-supported image formats, use an
external thumbnailer. This will give us the ability to:
- cancel running thumbnail operations
- avoid memory leaks, buffer overflows, double-frees, etc. in the
  image loaders having an impact on the application
- limit resource usage when thumbnailing

Review of attachment 330398 [details] [review]:

Looks good to me, fwiw

*** Bug 765054 has been marked as a duplicate of this bug. ***

Created attachment 341822 [details] [review]
thumbnail: Remove unused constant

Created attachment 341823 [details] [review]
thumbnail: Remove gnome_desktop_thumbnail_scale_down_pixbuf()

gnome-desktop is not a general purpose library for use by application
developers, but rather a convenience library for core desktop components
to share code. As such, it has no guarantee of API stability, and we can
remove functions without having to obsolete them.

Having said that, the internal user of this function was removed in bug
768064, and external users should be using the default gdk-pixbuf
scaling functions. If specific changes need to be made to those, they'll
need to be handled separately.

Review of attachment 341822 [details] [review]:

sure

Review of attachment 341823 [details] [review]:

Looks fine to me

Comment on attachment 341823 [details] [review]
thumbnail: Remove gnome_desktop_thumbnail_scale_down_pixbuf()

I've moved this patch to bug 775991, as there are some applications that depend on it.

Attachment 330398 [details] pushed as b69fde6 - thumbnail: Always use external gdk-pixbuf thumbnailer
Attachment 341822 [details] pushed as dba6d95 - thumbnail: Remove unused constant

I think this regressed svg thumbnail support: https://bugzilla.gnome.org/780956

(In reply to Jeremy Bicha from comment #10)
> I think this regressed svg thumbnail support:
> https://bugzilla.gnome.org/780956

I know it breaks librsvg thumbnails, that's why I filed bug 778666 :)