After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767965 - Improve heuristics to detect remote filesystem
Improve heuristics to detect remote filesystem
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on: 767963 767964
Blocks:
 
 
Reported: 2016-06-23 06:32 UTC by Ondrej Holy
Modified: 2016-06-28 09:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkfilesystem: Improve heuristics to detect remote filesystem (2.02 KB, patch)
2016-06-23 06:32 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2016-06-23 06:32:32 UTC 
Created attachment 330235 [details] [review]
gtkfilesystem: Improve heuristics to detect remote filesystem

GTK+ contains helper function _gtk_file_consider_as_remote  for remote locations, which is based on hardcoded list of filesystem types:
https://git.gnome.org/browse/gtk+/tree/gtk/gtkfilesystem.c#n905

It would be really nice to provide this information directly from GIO layer and do not use hardcoded lists as suggested by Matthias:
https://bugzilla.gnome.org/show_bug.cgi?id=754746#c3

Let's add/set/use G_FILE_ATTRIBUTE_FILESYSTEM_REMOTE for this need.

I tested the patches successfully using gtk+/tests/testfilechooser.
Comment 1 Matthias Clasen 2016-06-24 21:06:08 UTC 
Review of attachment 330235 [details] [review]:

Looks fine, once the support for this attribute in gio and gvfs.
Comment 2 Matthias Clasen 2016-06-24 21:06:17 UTC 
Review of attachment 330235 [details] [review]:

Looks fine, once the support for this attribute in gio and gvfs.
Comment 3 Ondrej Holy 2016-06-28 09:03:56 UTC 
Comment on attachment 330235 [details] [review]
gtkfilesystem: Improve heuristics to detect remote filesystem

Thanks, pushed as commit 0c1cc98.