GNOME Bugzilla – Bug 766494
souphttpclientsink: Add tls-database and tls-interaction
Last modified: 2018-05-06 13:19:22 UTC
Created attachment 327954 [details] [review] souphttpsink: Add GTlsInteraction and GTlsDatabase properties Required when the server requests a client certificate, aligns souphttpclientsink with souphttpsrc. Depends on patch in https://bugzilla.gnome.org/show_bug.cgi?id=759145. Originates from patch in https://bugzilla.gnome.org/show_bug.cgi?id=750709
Thanks for the patch, it looks fine to me. Could you make a patch that doesn't depend on #759145 and applies cleanly to master, and update the Since markers to 1.10?
Created attachment 327964 [details] [review] [PATCH] souphttpsink: Add GTlsInteraction and GTlsDatabase properties
I've updated v1.8 to v1.10. Would it be possible to review #759145 and commit before reviewing this one? Backing out and reapplying patches and then resolving the inevitable conflicts causes a lot of inconvenience on our side.
I'm not minded to apply the other one at the moment, but this one seems more straight-forward.
commit 64e4df3fe28c2e1d01eb0cf30c5a9c13d7cd2135 Author: Xavier Claessens <xavier.claessens@collabora.com> Date: Tue Jun 2 16:15:35 2015 -0400 souphttpsrc: Add tls-database property https://bugzilla.gnome.org/show_bug.cgi?id=750298 commit 10044b1d0f4140b1165d3f15807cfa072caef45e Author: Xavier Claessens <xavier.claessens@collabora.com> Date: Wed Jun 10 09:17:08 2015 -0400 souphttpsrc: Add GTlsInteraction property https://bugzilla.gnome.org/show_bug.cgi?id=750709