GNOME Bugzilla – Bug 766163
Some header files missing in sys/applemedia/ in gst-plugins-bad-1.8.1.tar.xz
Last modified: 2016-07-18 08:24:53 UTC
When building gst-plugins-bad on OSX 10.11.4 using the [Homebrew formula](https://github.com/Homebrew/homebrew-core/blob/master/Formula/gst-plugins-bad.rb) with the `with-applemedia` flag, following error occurs: ``` /Applications/Xcode.app/Contents/Developer/usr/bin/make -C shm ... plugin.m:25:10: fatal error: 'corevideomemory.h' file not found #include "corevideomemory.h" ``` This seems to be caused by [gst-plugins-bad-1.8.1.tar.xz](https://gstreamer.freedesktop.org/src/gst-plugins-bad/gst-plugins-bad-1.8.1.tar.xz) not containing said `corevideomemory.h` file. The file is however present in [the gst-plugins-bad git repo](https://github.com/GStreamer/gst-plugins-bad/blob/1.8.1/sys/applemedia/corevideobuffer.h). Reported in Homebrew-core as [#1006](https://github.com/Homebrew/homebrew-core/issues/1006)
commit 43487482e5c5ec71867acb887d50b8c3f813cd63 Author: Sebastian Dröge <sebastian@centricular.com> Date: Mon May 9 12:50:47 2016 +0300 applemedia: Ship all headers in tarballs Some were missing from noinst_HEADERS. https://bugzilla.gnome.org/show_bug.cgi?id=766163
Oops, link to file in git repo should be https://github.com/GStreamer/gst-plugins-bad/blob/1.8.1/sys/applemedia/corevideomemory.h, not https://github.com/GStreamer/gst-plugins-bad/blob/1.8.1/sys/applemedia/corevideobuffer.h
sys/applemedia/iosurfacememory.h (https://github.com/GStreamer/gst-plugins-bad/blob/1.8.1/sys/applemedia/iosurfacememory.h) seems to be missing as well.
Yes, I added them both.
Shouldn't this one go to 1.8.x branch?
Josep: looks like it! Please cherry-pick it.
The issue affected the 1.8.2 tarball too. I've cherry-picked the change to address it in 1.8.3