After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764795 - Short circuit gegl_node_set_passthrough if the value is same
Short circuit gegl_node_set_passthrough if the value is same
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks: 764801
 
 
Reported: 2016-04-08 15:50 UTC by Debarshi Ray
Modified: 2016-04-18 13:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GeglNode: Short circuit gegl_node_set_passthrough if the value is same (782 bytes, patch)
2016-04-08 15:51 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2016-04-08 15:50:05 UTC 
Calling gegl_node_set_passthrough with the same argument as node->priv->passthrough shouldn't needless invalidate the GeglNode. Would be nice if we were smart about this instead of expecting applications to be more careful.
Comment 1 Debarshi Ray 2016-04-08 15:51:05 UTC 
Created attachment 325596 [details] [review]
GeglNode: Short circuit gegl_node_set_passthrough if the value is same
Comment 2 Debarshi Ray 2016-04-18 13:35:07 UTC 
From #gegl on GIMPNet:

13:21 <rishi> Do you think https://bugzilla.gnome.org/show_bug.cgi?id=764795    
      and https://bugzilla.gnome.org/show_bug.cgi?id=764797 are OK to push?
13:21 <rishi> The test suite passes.
13:22 <rishi> I keep asking because a gnome-photos patch series needs           
      them. See the "blocks field.
13:28 <pippin> rishi: just push :)
13:29 <rishi> pippin: Ok. Pushing.
Comment 3 Debarshi Ray 2016-04-18 13:35:22 UTC 
commit c40abe78e8c5501e03afd4d4b50285f92cc2f574
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Fri Apr 8 17:05:10 2016 +0200

    GeglNode: Short circuit gegl_node_set_passthrough if the value is same
    
    https://bugzilla.gnome.org/show_bug.cgi?id=764795