After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763832 - backends: Add flags to MetaMonitorMode
backends: Add flags to MetaMonitorMode
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks: 763833
 
 
Reported: 2016-03-17 19:05 UTC by Rui Matos
Modified: 2016-05-13 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
backends: Add flags to MetaMonitorMode (4.64 KB, patch)
2016-03-17 19:05 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2016-03-17 19:05:10 UTC 
In bug 655041, we decided that breaking the DBus API so close to the
release wouldn't be a good idea so I'm proposing that we merge this
after we branch for 3.20 .
Comment 1 Rui Matos 2016-03-17 19:05:14 UTC 
Created attachment 324208 [details] [review]
backends: Add flags to MetaMonitorMode

And export them in the DBus API since they're useful for
gnome-control-center.
Comment 2 Bastien Nocera 2016-03-18 11:01:21 UTC 
Review of attachment 324208 [details] [review]:

::: src/org.gnome.Mutter.DisplayConfig.xml
@@ +135,3 @@
       <arg name="crtcs" direction="out" type="a(uxiiiiiuaua{sv})" />
       <arg name="outputs" direction="out" type="a(uxiausauaua{sv})" />
+      <arg name="modes" direction="out" type="a(uxuudu)" />

Couldn't we start using a protocol that's more extensible? a(a{sv}) maybe?

If we consider that it's not a problem (it's a private API after all), then this looks fine to me.
Comment 3 Rui Matos 2016-05-13 16:59:46 UTC 
Attachment 324208 [details] pushed as 1141929 - backends: Add flags to MetaMonitorMode