GNOME Bugzilla – Bug 762860
sdp: Add new sdpsrc element and some sdpdemux bugfixes
Last modified: 2016-03-25 10:52:55 UTC
See commit messages.
Created attachment 322634 [details] [review] sdpdemux: Only create RTCP part of the pipeline if RTCP is signalled in the SDP
Created attachment 322635 [details] [review] sdp: Add new sdpsrc element This can read from an SDP file or get the SDP data via property. Works around the problem that sdpdemux inside decodebin fails because the GST_STATE_CHANGE_NO_PREROLL is not observed by the pipeline. See https://bugzilla.gnome.org/show_bug.cgi?id=702495
Created attachment 322636 [details] [review] sdpdemux: Add pads with the correct names in case an rtpbin is used They're supposed to be stream_%u and not recv_rtp_src_%u_%u_%u.
Created attachment 322637 [details] [review] sdpdemux: Set caps to application/x-rtp instead of application/x-unknown as returned by the SDP helpers The SDP helpers can't know if this is going to be RTP, SRTP, or ....
Created attachment 322639 [details] [review] sdp: Add new sdpsrc element This can read from an SDP file or get the SDP data via property. Works around the problem that sdpdemux inside decodebin fails because the GST_STATE_CHANGE_NO_PREROLL is not observed by the pipeline. See https://bugzilla.gnome.org/show_bug.cgi?id=702495
Comment on attachment 322634 [details] [review] sdpdemux: Only create RTCP part of the pipeline if RTCP is signalled in the SDP This is actually wrong. If no rtcp attribute is in the SDP, it's supposed to be the next higher port.
Comment on attachment 322637 [details] [review] sdpdemux: Set caps to application/x-rtp instead of application/x-unknown as returned by the SDP helpers This one is a regression from 1.6
Comment on attachment 322636 [details] [review] sdpdemux: Add pads with the correct names in case an rtpbin is used This one a regression from the 0.10 port it seems
Created attachment 322828 [details] [review] sdp: Add new sdpsrc element This can read from an SDP file or get the SDP data via property. Works around the problem that sdpdemux inside decodebin fails because the GST_STATE_CHANGE_NO_PREROLL is not observed by the pipeline. See https://bugzilla.gnome.org/show_bug.cgi?id=702495
Attachment 322828 [details] pushed as b53f682 - sdp: Add new sdpsrc element