GNOME Bugzilla – Bug 761462
event: Get rid of timestamp field
Last modified: 2018-05-06 15:39:07 UTC
I just GstEventaully realised that today is the good time to begin getting rid of GstEvent::timestamp usage in gst-plugins-* repos. Field itself will be removed in 2.0 API and should be kept now to preserve 1.x API / ABI compatibility.
Created attachment 320271 [details] [review] tagdemux: avoid timestamp field initialization for tag event
Review of attachment 320271 [details] [review]: I will tweak message a bit.
Created attachment 320275 [details] [review] tagdemux: avoid timestamp field initialisation for tag event
Created attachment 320276 [details] [review] icydemux: avoid timestamp field initialisation for tag event
Created attachment 320280 [details] [review] gdp: ignore timestamp of event
Anyone uses timestamp of "highlight" event (from bad plugin resindvd)? https://bugzilla.gnome.org/show_bug.cgi?id=761477
basesink might do something based on the timestamp of the SEGMENT event for waiting, I remember something. Or maybe not. Needs to be checked. In general, getting rid of the timestamp in GstEvents and GstMessages sounds like a good idea for 2.0
I didn't found timestamp usage in basesink. What do you think about cleanup timestamp usage in random places before getting rid of it in structures?
commit b4df0bf07afd6292786034ae424d8969310a779b (HEAD -> master, origin/master, origin/HEAD) Author: Kyrylo Polezhaiev <kirushyk@gmail.com> Date: Tue Feb 2 18:19:30 2016 +0200 tagdemux: avoid timestamp field initialisation for tag event This field is not used and will be removed in 2.0 API. https://bugzilla.gnome.org/show_bug.cgi?id=761462 commit 70a55f90a3686836a956e61d367aec96cc6d3c3b (HEAD -> master) Author: Kyrylo Polezhaiev <kirushyk@gmail.com> Date: Tue Feb 2 18:58:24 2016 +0200 icydemux: avoid timestamp field initialisation for tag event This field is not used and will be removed in 2.0 API. https://bugzilla.gnome.org/show_bug.cgi?id=761462 commit 48dd94a890e53b468bc8350f1b50237ba4a8f611 (HEAD -> master) Author: Kyrylo Polezhaiev <kirushyk@gmail.com> Date: Tue Feb 2 19:18:26 2016 +0200 gdp: ignore timestamp of event This field is not used and will be removed in 2.0 API. https://bugzilla.gnome.org/show_bug.cgi?id=761462 commit 4ccc51ce15c03741aa9a8192c5092362063ca9cb (HEAD -> master) Author: Jan Schmidt <jan@centricular.com> Date: Mon May 7 01:32:14 2018 +1000 gstevent: Add some FIXME: 2.0 about removing the timestamp The timestamp field isn't valuable or used well anywhere. We should remove it for GStreamer 2.0 https://bugzilla.gnome.org/show_bug.cgi?id=761462