After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757212 - [Location Bar] The second line of the highlighted history element in the dropdown is hard to see
[Location Bar] The second line of the highlighted history element in the drop...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
3.20.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 755518
 
 
Reported: 2015-10-27 19:40 UTC by Julián Unrrein
Modified: 2018-02-12 23:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Highlighted entry in dropdown menu. (188.07 KB, image/png)
2015-10-27 19:40 UTC, Julián Unrrein
Details
Highlighted entry in dropdown menu (3.20.3 version) (120.53 KB, image/png)
2016-08-21 18:32 UTC, Julián Unrrein
Details
Highlighted entry (3.20.3) (correct version) (121.08 KB, image/png)
2016-08-21 18:36 UTC, Julián Unrrein
Details

Description Julián Unrrein 2015-10-27 19:40:22 UTC
Created attachment 314255 [details]
Highlighted entry in dropdown menu.

In a highlighted dropdown element, the second line of text (the URL) is hard to see because the contrast because of the grey color of the text and the blue background.

See attachment.
Comment 1 Michael Catanzaro 2015-10-27 19:54:33 UTC
Are you really using 3.18? I thought we fixed this for 3.18. :/ I know it's broken in master again due to theme changes....
Comment 2 Julián Unrrein 2015-10-27 20:05:19 UTC
Running "epiphany --version" in console outputs "Web 3.18.0".

I'm using OpenSUSE Tumbleweed by the way.
Comment 3 Julián Unrrein 2015-10-27 20:35:47 UTC
Also using Gtk 3.18.1.
Comment 4 Michael Catanzaro 2016-06-13 23:49:16 UTC
This one's fixed.
Comment 5 Julián Unrrein 2016-08-21 18:32:07 UTC
I'm sorry if it's bad practice to comment on closed reports, but this bug isn't fixed in Epiphany 3.20.3. See attachment.
Comment 6 Julián Unrrein 2016-08-21 18:32:51 UTC
Created attachment 333834 [details]
Highlighted entry in dropdown menu (3.20.3 version)
Comment 7 Julián Unrrein 2016-08-21 18:36:29 UTC
Created attachment 333835 [details]
Highlighted entry (3.20.3) (correct version)
Comment 8 Michael Catanzaro 2016-08-21 20:27:09 UTC
(In reply to Julián Unrrein from comment #5)
> I'm sorry if it's bad practice to comment on closed reports

No, that's fine.

> but this bug
> isn't fixed in Epiphany 3.20.3. See attachment.

It should really use white text rather than dark gray. In 3.18 and prior it used light gray, which was even worse to read.

This is not a simple fix as we have to dig into GdTwoLinesRenderer. There are hardcoded color values there, which is wrong, but apparently we don't get reasonable theme colors from GTK+ anymore.
Comment 9 Jan-Michael Brummer 2018-02-12 18:14:07 UTC
Within the current version the second line is readable. Is there anything else to do?
Comment 10 Michael Catanzaro 2018-02-12 23:37:40 UTC
I don't remember when or how this was fixed, or whether it was done by me or by somebody else, but yes the text is obviously much more readable now than it used to be.