GNOME Bugzilla – Bug 756807
Windows' titles are unreadable in Gnome Classic's bottom panel/window list
Last modified: 2017-11-24 18:07:45 UTC
Created attachment 313657 [details] Missing window's title It seems that some styling issues are preventing windows' titles from being noticed on the bottom panel/window list. When a mouse hover is performed on a window element, the changed styling still exhibits the problem. I am using GNOME 3.18.1-2 from Arch Linux.
Created attachment 314137 [details] [review] window-list button colors - not sure I win the override game
(In reply to Jakub Steiner from comment #1) > window-list button colors This patch has landed - is there anything left to do, or can the bug be closed?
*** Bug 757373 has been marked as a duplicate of this bug. ***
Created attachment 314559 [details] patch applied It surely looks better. However, the buttons are still rather dark which looks somewhat inconsistent with the other colors in the theme. It feels a bit disruptive to me and I'm not sure if that is intentional. Sorry if I'm just bikeshedding
Created attachment 315638 [details] [review] patched css for GNOME Classic
Created attachment 315639 [details] [review] patched css for GNOME "normal" What do you think about these 2 patches? For me its hard to distinguish between normal, focused and minimised windows in current themes. I did some tweaks to both css files so there are some changes in "normal" gnome shell and also in gnome classic I tried to fix some problems including this bug. Please review.
Created attachment 315640 [details] screenshow after patch windows list will look like this after css tweaks
Created attachment 315660 [details] [review] patched css for GNOME Classic minor cleanup
Created attachment 315697 [details] [review] window-list theme fixes GNOME 3.18.2 still has some issues, this patch should fix them black theme: - make focused window button slightly more dominant classic theme: - included -st-natural-width and max-width from black theme - removed non working gradients - fixed too bright text color on focused window button - adjusted colors and added hover effect what do you think?
It looks a lot better to me with the patch applied
Created attachment 315700 [details] [review] window-list theme fixes -- fixed color adjusted text color to match classic theme
Created attachment 315711 [details] [review] window-list theme fixes Changed and removed some things that were driving me crazy.. Sorry for spamming, this will be my final comment :) changes made to GNOME 3.18.2: black theme: - focused window button is now slightly more dominant classic theme: - included -st-natural-width and max-width from black theme - use same .window-button padding as black theme, since both themes have height: 2.25em; - removed gradients that doesn't seem to work - fixed too bright text color on focused window button - adjusted colors and added hover effect
Created attachment 316342 [details] Screenshot of the window list with gnome-shell 3.18.3 I've updated my Fedora 23 system, it's now better, but there is still a problem. The text in white is hard to read.
I believe the [white] text from the focused window button is indeed still very hard to read.
We can also see the bug in GNOME Continuous: http://build.gnome.org/continuous/buildmaster/builds/2016/03/12/34/smoketest-classic/work-gnome-continuous-x86_64-runtime/screenshot-final.png So it's still not fixed for 3.20. And the bug is still present in 3.18. It's a quite major problem for the GNOME Classic session.
Created attachment 324382 [details] [review] classic theme patch Bottom bar looks much better to me after applying some css tweaks. Can you commit this patch?
ping A patch has been sent. Can a maintainer look at it?
Review of attachment 324382 [details] [review]: Unfortunately this CSS file is generated from the SCSS. Can you patch the source file?
Created attachment 327596 [details] [review] 0001-Fix-colors-of-window-list-classic-theme.patch Is it okay now?
Created attachment 327598 [details] [review] panel style changes - based on a patch by rudolf@palaticky.com - having three css locations with hardcoded colors, what could possibly go wrong in the future. :(
Comment on attachment 327598 [details] [review] panel style changes Attachment 327598 [details] pushed as 59aa0f6 - panel style changes
There's small typo on line 15 that wasn't in original patch, not sure if it makes any visible difference -st-natural-width: 18.7em; -st-natural-width: 18.75em;
Created attachment 331613 [details] [review] Fix minimized window style Jakub, I installed SLED 12 SP2 with gnome 3.20 a while ago and noticed that minimized window buttons have wrong style. Then I checked commit 59aa0f66f34be85131aab574a1a8d69b02ea236c and there is error in that patch.. this: .bottom-panel .window-button.minimized > StWidget { box-shadow: inset 1px 1px 1px rgba(0,0,0,0.5); } should be this: .bottom-panel .window-button.minimized:active > StWidget { box-shadow: inset 1px 1px 1px rgba(0,0,0,0.5); } Could you please apply patch based on my attachment to 3.20 and 3.21 branch? It also fixes previous -st-natural-width typo.
Pretty sure this was fixed in bug 775282.