GNOME Bugzilla – Bug 754047
glupload: Loses overlay meta when using raw uploader
Last modified: 2015-08-28 18:27:56 UTC
When the raw uploaded is picked, the composition meta isn't copied over, which lead to the loss of overlay. This is a regression in 1.5. gst-launch-1.0 v4l2src io-mode=mmap ! textoverlay text=YEAH font-desc="Arial 60" ! glimagesink The reason seemed that we override prepare_buffer(), which default implementation is responsible for copying metas.
Created attachment 309935 [details] [review] glcolorconvert: Use base transform metadata copy Use base class default method instead of only copying flags and timestamp. This way, selected meta's like compostion overlay will be passed downstream as expected.
Created attachment 309936 [details] [review] glupload: Use base class metadata copy function This allow properly copying selected meta, like the composition overlay. Note that output buffer need to be readable, but GlUpload keeps a ref. For now, simply drop GlUpload ref after perform, leaving that ref has no purpose. The method shall be removed in the future.
Comment on attachment 309936 [details] [review] glupload: Use base class metadata copy function Do we also have this release problem with gldownload/glcolorconvert? If so, let's fix it in one go.
(In reply to Sebastian Dröge (slomo) from comment #3) > Comment on attachment 309936 [details] [review] [review] > glupload: Use base class metadata copy function > > Do we also have this release problem with gldownload/glcolorconvert? If so, > let's fix it in one go. Only glupload have such a release method. This though, isn't the only inconsistency in the API. gst_gl_download_set_format() vs gst_gl_upload_set_caps(). Then the set of extra helpers seems to vary, though nothing major for the rest. I think we should not revisit the API now, but wait for 1.7 (and try and work out something we think can be made stable, stripping off anything not essential).
Attachment 309935 [details] pushed as b06fc67 - glcolorconvert: Use base transform metadata copy Attachment 309936 [details] pushed as ae6f4a2 - glupload: Use base class metadata copy function
(In reply to Nicolas Dufresne (stormer) from comment #4) > (In reply to Sebastian Dröge (slomo) from comment #3) > > Comment on attachment 309936 [details] [review] [review] [review] > > glupload: Use base class metadata copy function > > > > Do we also have this release problem with gldownload/glcolorconvert? If so, > > let's fix it in one go. > > Only glupload have such a release method. This though, isn't the only > inconsistency in the API. > > gst_gl_download_set_format() vs gst_gl_upload_set_caps(). Then the set of > extra helpers seems to vary, though nothing major for the rest. > > I think we should not revisit the API now, but wait for 1.7 (and try and > work out something we think can be made stable, stripping off anything not > essential). Agreed, can you create a reminder bug about that? :)
For the reference, https://bugzilla.gnome.org/show_bug.cgi?id=754094