GNOME Bugzilla – Bug 753394
"Select Custom Icon" should propose an icon view
Last modified: 2021-06-18 15:53:08 UTC
Created attachment 308951 [details] Select custom icon dialog When selecting icons, the dialog shows a List view, which is not adapted. Every image is extra small, so you have to click on these to so a small preview. Since the whole point of selecting an icon (likely searching it in a directory which would be full of pictures or icons) is to choose an image, wouldn't it make more sense to have this file selection dialog appear in an Icon view format, where images are at least previewable without having to click them? Nautilus 3.16.2
I'd like to add, that the "select custom icon" window is unresponsive to mouse clicks or any keyboard keys, except the escape key, which is the only way to close the dialogue, in the current version (3.20.1) (Yes, I know that this should be a new bug, but why not kill 2 birds with one stone?) In addition to what Jehan said, I'd like to mention that other apps (such as Gnome Pie https://simmesimme.github.io/gnome-pie.html) have much better icon choosers, and they all seem to use the same underlying code/template.
Created attachment 327531 [details] [review] properties-window: make icon chooser dialog modal The custom icon selection GtkFileChooserDialog is unresponsive when opened. This can be fixed by making the dialog modal.
Review of attachment 327531 [details] [review]: The fact of getting the focus solely on the new window is indeed a side effect of making it modal, but not the fix for this if we want to keep the previous behaviour of not making it modal (but we want to make it modal). So could you write something in the commit message along the lines of: The custom icon selection GtkFileChooserDialog doesn't respond to keyboard keys when opened. The fix would be to grab the focus on the new window. However, lately we are making all the dialogs modal following the design guidelines, which implicitly grabs the focus. So we can just make the dialog modal and as a side effect fix this. Feel free to commit with the commit message fixed. Thanks for your work Ernestas!
Huh, I thought gtk_window_present() grabbed focus. Sure, I’ll rewrite the message.
(In reply to Ernestas Kulik from comment #4) > Huh, I thought gtk_window_present() grabbed focus. > > Sure, I’ll rewrite the message. wait...of course, it should. But then maybe we steal it somewhere else? If not I understood wrong the bug... The thing is that, once we present the window and the focus is in the new window, the widget should behave as expected.
Created attachment 327632 [details] [review] properties-window: make icon chooser dialog modal The custom icon selection GtkFileChooserDialog is unresponsive when opened. This is caused by the properties dialog window being modal, since it is up to the window manager how to process input in such situations. One of the ways to ensure that the child dialog receives and processes user input is by making it modal. This commit makes it such.
Review of attachment 327632 [details] [review]: Sounds good, thanks!
Comment on attachment 327632 [details] [review] properties-window: make icon chooser dialog modal Attachment 327632 [details] pushed as 6df5972 - properties-window: make icon chooser dialog modal
Is there any workaround for the unresponsive icon chooser in the meantime? (E.g. editing a config. file somewhere to set the icon?) Can someone retitle this bug to relate to the unresponsiveness issue, and split the original bug off to a new one? Difficult to find that this has been fixed otherwise.
Sorry, answered my own question about a workaround. For others' reference: gvfs-set-attribute /path/to/file metadata::custom-icon-name some-icon-name
I'd like to mention that the the "select custom icon" window has been fixed and is now responsive to mouse clicks again in the latest bersion of nautilus (3.20.2). Jehan's issue is still topical however. Just though I'd mention this, because I found it funny how all Stephen had to do was update his installation of nautilus.
No it isn't fixed in 3.20.2.
It's fixed for me, so I guess either the bug is caused from something else of which I have a newer version than you, or the bug only affects some systems, perhaps periodically. ¯\_(ツ)_/¯
This bug is not about the unresponsive icon chooser, fixed in comment #8. We should had make the reporter file a new bug report about this or file ourselves and attached the patch there. So sorry for the confusion.
(In reply to Stephen from comment #9) > Is there any workaround for the unresponsive icon chooser in the meantime? > (E.g. editing a config. file somewhere to set the icon?) > > Can someone retitle this bug to relate to the unresponsiveness issue, and > split the original bug off to a new one? Difficult to find that this has > been fixed otherwise. Bug 767229 is the designated tracking bug. (In reply to Stephen from comment #12) > No it isn't fixed in 3.20.2. Reply to bug 767229 or file a new report. Make sure you have 3.20.2 installed first.
Comment 0 suggests file chooser to use an icon grid. Unfortunately, file chooser does not support such icon grid view: bug 141154. Adding dependency. Comment 1 suggests a special purpose icon chooser, which is the subject of bug 611233.
*** Bug 611233 has been marked as a duplicate of this bug. ***
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of Files (nautilus), then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/nautilus/-/issues/ Thank you for your understanding and your help.