After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748111 - Use PKG_PROG_PKG_CONFIG for pkg-config detection
Use PKG_PROG_PKG_CONFIG for pkg-config detection
Status: RESOLVED FIXED
Product: libsecret
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsecret maintainer(s)
libsecret maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-04-18 16:07 UTC by Marvin Schmidt
Modified: 2016-03-25 10:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use PKG_PROG_PKG_CONFIG (805 bytes, patch)
2015-04-18 16:07 UTC, Marvin Schmidt 		committed Details | Review

Description Marvin Schmidt 2015-04-18 16:07:16 UTC 
Created attachment 301906 [details] [review]
use PKG_PROG_PKG_CONFIG

Using the PKG_PROG_PKG_CONFIG macro instead of AC_PATH_PROG allows easy cross-compilation since it also looks for a pkg-config binary prefixed with the given host-triplet (e.g. i686-pc-linux-gnu-pkg-config when passing --host=i686-pc-linux-gnu to cross-compile for x86)
Comment 1 Stef Walter 2015-04-23 06:03:06 UTC 
Where is PKG_PROG_PKG_CONFIG defined? Wouldn't this cause an unintelligible error if pkg-config.m4 (or whatever) isn't installed?
Comment 2 Marvin Schmidt 2015-04-23 07:48:39 UTC 
The PKG_PROG_PKG_CONFIG macro is defined in pkg.m4 shipped with pkg-config. And sure, as every other macro it has to be available when (re)generating the autotools files. But it's not possible to do so without having that macro since other macros such as GTK_DOC_CHECK and VAPIGEN_CHECK use PKG_PROG_PKG_CONFIG as well
Comment 3 Stef Walter 2015-04-23 07:50:10 UTC 
Okay, sounds fine.
Comment 4 Marc-Antoine Perennou 2016-03-25 10:14:54 UTC 
pushed as cdf7b1cf2b33c36638775227a30ba3e0bea50e8c
Comment 6 Marvin Schmidt 2016-03-25 10:48:03 UTC 
Thanks for pushing!