GNOME Bugzilla – Bug 747021
provide a scalable -symbolic variant of the app icon
Last modified: 2015-04-30 15:50:54 UTC
Starting with GNOME 3.16 we streamlined how high contrast icons are managed. The attached patch includes a symbolic variant of the app icon that is used for HC theme and recolorable at runtime. See https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons for more details.
Created attachment 300583 [details] [review] icon: provide a symbolic variant of the app icon since gnome 3.16 we're perusing the symbolic icon for high contrast theme
Three problems: * As <circle> is used, the icon do not work as a symbolic one (not highlighted in the topbar). Circles should probably be transformed in a path, as I did for Iagno’s symbolic icon. * I find the dark color hard to read in the topbar. That’s the reason why, for Iagno, I continue to use the “white border” thing (but I probably do a bad thing letting one circle empty, even if there are not case where that could be seen for now; but that’s another story). * The circle in the bottom of the second column should be dark, or the drawn position is not playable.
Review of attachment 300583 [details] [review]: Changing patch status to reflect Arnaud's review. Thanks Jakub!
Created attachment 300592 [details] [review] icon: provide a symbolic variant of the app icon since gnome 3.16 we're perusing the symbolic icon for high contrast theme
Created attachment 300596 [details] Screenshot. The updated patch solves the first issue (the technical one).
Review of attachment 300592 [details] [review]: To be clear about what Arnaud was requesting: this patch reintroduces bug #677638, where there are two different lines of four circles of the same color in a row, which is not a possible game position. You can avoid that by swapping the color for one of the circles, preferably the second circle from the left in the bottom row, to match the highcolor icon.
Created attachment 302665 [details] [review] icon: provide a symbolic variant of the app icon since gnome 3.16 we're perusing the symbolic icon for high contrast theme
Super, thanks! Attachment 302665 [details] pushed as 5626fda - icon: provide a symbolic variant of the app icon