After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743518 - qtdemux: dead code while calculating segment base ?
qtdemux: dead code while calculating segment base ?
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal minor
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-26 10:51 UTC by Aurélien Zanelli
Modified: 2015-01-28 19:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Aurélien Zanelli 2015-01-26 10:51:06 UTC 
While investigating bug 743363, I read qtdemux segment handling and I found something strange in it.

segment.base can be calculated twice in this code and the latter override the former:
http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/gst/isomp4/qtdemux.c#n3669

Since I'm not familiar with qtdemux and segment, I don't know if it's just dead code or not.
Comment 1 Thiago Sousa Santos 2015-01-28 03:03:50 UTC 
Indeed that is dead code and the segment.base handling seems odd. Need to check what that dead code was meant to do.
Comment 2 Thiago Sousa Santos 2015-01-28 19:19:48 UTC 
Thanks for reporting, the override could be covered by the previous math if the 'stop' field had been set correctly a few lines above.

commit 9a9d4ecceabd0de3632f588ce5d89d7ba78b5490
Author: Thiago Santos <thiagoss@osg.samsung.com>
Date:   Wed Jan 28 14:02:15 2015 -0300

    qtdemux: simplify segment.base math
    
    Remove a fix for heavily edited files added for fixing
    https://bugzilla.gnome.org/show_bug.cgi?id=345830 to work
    with seeks and proper gaps playback. The fix was replaced
    for a more general solution that bases on using previous
    segment's duration, just like it works for media segments
    playback.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=743518