After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743405 - Add new roles for math content
Add new roles for math content
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
At-spi maintainer(s)
Depends on: 743403
Blocks:
 
 
Reported: 2015-01-23 15:15 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2015-01-26 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.31 KB, patch)
2015-01-23 15:15 UTC, Joanmarie Diggs (IRC: joanie)
needs-work Details | Review
Also bump minimum version of AT-SPI2 (1.46 KB, patch)
2015-01-26 13:41 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2015-01-23 15:15:06 UTC
Created attachment 295280 [details] [review]
Proposed patch

New roles for fractions, roots, subscripts, and superscripts were added to ATK (see bug 742806). We need them in AT-SPI2 now. Patch attached.
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2015-01-26 13:01:17 UTC
Review of attachment 295280 [details] [review]:

::: configure.ac
@@ +52,3 @@
 AC_SUBST(GMODULE_CFLAGS)
 
+PKG_CHECK_MODULES(ATK, [atk >= 2.15.4])

In addition to a bump on atk dependency, it also needs a bump on at-spi2-core dependency, the one adding the at-spi2 roles.
Comment 2 Joanmarie Diggs (IRC: joanie) 2015-01-26 13:41:15 UTC
Created attachment 295450 [details] [review]
Also bump minimum version of AT-SPI2

Done.

I noticed that Mike did a post-release version bump of at-spi2-core, so this patch won't break the build. By the same token, there has not been a release of the bumped-to version of at-spi2-core. Assuming the patch is acceptable, should we wait until after the next release to commit it?
Comment 3 Mike Gorse 2015-01-26 15:17:50 UTC
Comment on attachment 295450 [details] [review]
Also bump minimum version of AT-SPI2

I'm not planning on making another release until the next deadline, but I don't see a reason not to commit the patch. People building modules from git should expect that they may also need to build modules that they depend on from git, and generally people are either using jhbuild (in which case they'll get the updated at-spi2-core first) or they're distributions building from tarballs (in which case they won't get this at-spi2-atk commit until the next release).
Comment 4 Joanmarie Diggs (IRC: joanie) 2015-01-26 15:50:38 UTC
Comment on attachment 295450 [details] [review]
Also bump minimum version of AT-SPI2

https://git.gnome.org/browse/at-spi2-atk/commit/?id=981d82459