GNOME Bugzilla – Bug 738588
[review] dcbw/unmanaged-available: fix activating default-unmanaged devices
Last modified: 2014-11-07 15:23:09 UTC
default-unmanaged devices are unmanaged until the user explicitly activates them. Unfortunately that was broken because no connections were in AvailableConnections for these devices. Next, shared connections were excluded from master device ignore carrier checks, which is wrong because they are effectively static/manual connections for the master device. Furthermore, because bridge/bond don't get a carrier until at least one of their slaves have a carrier, this meant that shared IP configuration was not applied to a bridge/bond with tun/tap/veth slaves (a common VM/container configuration such as the libvirt default) until a container/VM was started and attached to the tun/tap/veth (which only turn on the carrier when something is attached), which could be too late. Allow shared configurations to be started immediately on master devices, ignoring carrier state.
Looks good to me
me too
One additional patch for review. The others are unchanged: core: autoconnect fixes for default-unmanaged devices and property notification the previous patches allowed default-unmanaged devices to be autoconnected, which this patch fixes.
The branch seems fine to me.
>+ * nm_device_get_autoconnect: >+ * @self: the #NMDevice >+ * >+ * Returns: %TRUE if the device is explicitly blocking all autoconnect %FALSE otherwise looks good
(In reply to comment #5) > >+ * nm_device_get_autoconnect: > >+ * @self: the #NMDevice > >+ * > >+ * Returns: %TRUE if the device is explicitly blocking all autoconnect > > %FALSE > > otherwise looks good Fixed and merged to git master.