GNOME Bugzilla – Bug 737478
Rework adwaita gtk2 theme ( Part 2)
Last modified: 2014-12-05 13:49:27 UTC
Created attachment 287246 [details] Screenshot Continue my work at https://bugzilla.gnome.org/show_bug.cgi?id=735825. Improve: - Nicer notebook: because white background of notebook cause many issues with entry, button,.. - Nicer button pressed state - Nicer ranger - Nicer scrollbar - Nicer menu and some minor tweaks. Theme is now more polish (even with non-Gtk widget as Qt,...) and more consistent with Gtk 3. https://github.com/20115681/adwaita-gtk2
Good work, some comments. - I'm not really sure about the non lighter notebooks. - we don't do combobox-entries that way anymore so I'd use a normal button for that, same thing for spinbuttons - we use a border (lighter then standard borders) on the menubar now
- Notebook: I dont find any better solution for this problem. Native gtk applications support transparent in asset images but non-Gtk as Qt, for example, do not ! Therefore, i must fill all transparent border in assets with standard background color (#ededed) and also set background of notebook to same color for best combination. - ComboboxEntry, S.pinButton: Gtk2 is different with Gtk3 and many app still use these widgets. - I know but i can not do it because drawbacks of Gtk2 (or theme engine,...) ? Maybe someone know how do this
regarding comboboxentries and spinbutton, sorry I wasn't clear enough, I mean to make the buttons look like buttons (as we do for comboboxentries in the latest Adwaita) istead of entry embedded look. Regarding menubars I guess at the end of the day we could use an asset for that (background with darker line at the bottom). For qt apps I'd say I could live with that defect especially considering that there's an ongoing work to have a native qt adwaita.
Yes, i like this project https://github.com/MartinBriza/adwaita-qt. But this is official for Fedora Workstation, not for general GNOME. And looking issue is not only in Qt, but also in others (XUL,VCL,Java Swing,...).
Well, I'd mostly care about gtk2 apps, trying to tackle everything will make gtk2 stuff looking more alien that it could be
Created attachment 290266 [details] [review] Patch Hey. I made a patch for this change ( with lighter notebooks ).