GNOME Bugzilla – Bug 736013
replace deprecated widgets
Last modified: 2015-01-16 16:49:55 UTC
Created attachment 285317 [details] build.log Deprecated widgets shouldn't be used in the code of g-c-c. See warnings in the attached build.log. This is especially GtkMisc and GtkAlignment, which can be easily replaced by the GtkWidget properties. See manual for the details: https://developer.gnome.org/gtk3/unstable/GtkMisc.html#GtkMisc.description https://developer.gnome.org/gtk3/unstable/GtkAlignment.html#GtkAlignment.description
Created attachment 285318 [details] [review] um-editable-combo: avoid using deprecated GtkAlignment and GtkMisc
Created attachment 285319 [details] [review] um-editable-button: avoid using deprecated GtkAlignment and GtkMisc
Review of attachment 285318 [details] [review]: Looks fine.
Review of attachment 285319 [details] [review]: Looks good as well.
Created attachment 287832 [details] [review] cc-editable-entry: avoid using deprecated GtkAlignment and GtkMisc
Created attachment 287833 [details] [review] mouse: avoid using deprecated GtkAlignment and GtkMisc
Review of attachment 287832 [details] [review]: Looks good otherwise. ::: shell/cc-editable-entry.c @@ +237,3 @@ if (priv->width_chars != n_chars) { label = gtk_bin_get_child (GTK_BIN (priv->button)); + white space change.
Review of attachment 287833 [details] [review]: libgd change snuck in. Looks good otherwise.
Created attachment 288904 [details] [review] mouse: avoid using deprecated GtkAlignment and GtkMisc Libgd change snuck out...
Review of attachment 288904 [details] [review]: Looks good to commit after branching.
Comment on attachment 285318 [details] [review] um-editable-combo: avoid using deprecated GtkAlignment and GtkMisc commit d6a0c18f094694f14a9a4cc95b0147fd3c587aae
Comment on attachment 285319 [details] [review] um-editable-button: avoid using deprecated GtkAlignment and GtkMisc commit 946ff4eb3c80d7199c279f25a8aaae85e7bd8bcb
Comment on attachment 287832 [details] [review] cc-editable-entry: avoid using deprecated GtkAlignment and GtkMisc commit 192888fea4dcf10dc0139f8a6215499e4ede5e54
Comment on attachment 288904 [details] [review] mouse: avoid using deprecated GtkAlignment and GtkMisc commit 2640a9dfd7ac5ac51ac4aeb73e82916839bf8294
Created attachment 290182 [details] [review] cc-editable-entry: don't use deprecated xalign on GtkButton
Created attachment 290183 [details] [review] mouse: replace deprecated stuff
Created attachment 290184 [details] [review] user-accounts: replace deprecated stuff
Created attachment 290186 [details] [review] cc-language-chooser: remove deprecated GtkMisc
Hopefully this removes/replaces all deprecated stuff in my panels and get rid of those warnings :-)
Review of attachment 290184 [details] [review]: ok
Review of attachment 290186 [details] [review]: ok
Review of attachment 290183 [details] [review]: ::: panels/mouse/gnome-mouse-test.c @@ +310,3 @@ gtk_adjustment_get_upper (adjustment)); + provider = GTK_STYLE_PROVIDER (gtk_css_provider_new ()); This instance needs to be unrefed at the end below @@ +312,3 @@ + provider = GTK_STYLE_PROVIDER (gtk_css_provider_new ()); + gtk_css_provider_load_from_data (GTK_CSS_PROVIDER (provider), "* {background: #565854}", -1, NULL); + gtk_style_context_add_provider (gtk_widget_get_style_context (WID ("viewport")), provider, G_MAXUINT); GTK_STYLE_PROVIDER_PRIORITY_APPLICATION seems like the priority value that we should use here
Review of attachment 290182 [details] [review]: ok
Created attachment 291035 [details] [review] printers: Stop using x/yalign properties on CcEditableEntry instances Commit 192888fea4dcf10dc0139f8a6215499e4ede5e54 made this widget inherit from GtkBin instead of GtkAlignment and thus made this panel abort on load due to the properties in the .ui file becoming invalid.
Comment on attachment 290182 [details] [review] cc-editable-entry: don't use deprecated xalign on GtkButton commit bd5ac1078d8f3f29d9f740aa00f55df1cd6d4e2f
Comment on attachment 290184 [details] [review] user-accounts: replace deprecated stuff commit 320f6e617bb78f1ecea0ef974e90430daf3329c5
Comment on attachment 290186 [details] [review] cc-language-chooser: remove deprecated GtkMisc commit e9af927e5fa444206ac4b78d45b540a6295d4c6a
Comment on attachment 291035 [details] [review] printers: Stop using x/yalign properties on CcEditableEntry instances Marek was already fixing this crashes before some time, please discuss it with him :-)
Thanks for the reviews, I will fix the last patch soon...
Created attachment 291077 [details] [review] mouse: replace deprecated stuff
Review of attachment 291077 [details] [review]: looks fine
Comment on attachment 291077 [details] [review] mouse: replace deprecated stuff commit 71aca7abdb090ccf4ba5ba52e178ce799424f7ce
(In reply to comment #24) > Created an attachment (id=291035) [details] [review] > printers: Stop using x/yalign properties on CcEditableEntry instances > > Commit 192888fea4dcf10dc0139f8a6215499e4ede5e54 made this widget > inherit from GtkBin instead of GtkAlignment and thus made this panel > abort on load due to the properties in the .ui file becoming invalid. Hi, I've prepared a similar patch for this and some related issues here: https://bugzilla.gnome.org/show_bug.cgi?id=739737.
(In reply to comment #33) > (In reply to comment #24) > > Created an attachment (id=291035) [details] [review] [details] [review] > > printers: Stop using x/yalign properties on CcEditableEntry instances > > > > Commit 192888fea4dcf10dc0139f8a6215499e4ede5e54 made this widget > > inherit from GtkBin instead of GtkAlignment and thus made this panel > > abort on load due to the properties in the .ui file becoming invalid. > > Hi, > > I've prepared a similar patch for this and some related issues here: > https://bugzilla.gnome.org/show_bug.cgi?id=739737. Is that patch obsolete and the bug fixed then?
Comment on attachment 291035 [details] [review] printers: Stop using x/yalign properties on CcEditableEntry instances Yes, this is obsolete, however there are still some warnings about deprecated widgets while compiling, so I think the bug is valid...
(In reply to comment #35) > (From update of attachment 291035 [details] [review]) > Yes, this is obsolete, however there are still some warnings about deprecated > widgets while compiling, so I think the bug is valid... The few remaining ones should be gone when all the patches in bug 740986 and bug 691559 land